[Bug 31957] New: Translation : Ability to change the sentence structure in branches.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Bug ID: 31957 Summary: Translation : Ability to change the sentence structure in branches.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr I'm having trouble translating the sentences in branches.tt where it says the the default is a system preference. For example, line ~210 [% IF ( CAN_user_parameters_manage_sysprefs ) %] Default: <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLDefaultStaffEmail">ILLDefaultStaffEmail</a> system preference [% ELSE %] Default: ILLDefaultStaffEmail system preference [% END %] It comes out like this in translation msgid "%s Default: " msgid "ILLDefaultStaffEmail" msgid "" "system preference %s Default: ILLDefaultStaffEmail system preference %s " However, in French, the order of the words should be inverted, e.g. ILLDefaultStaffEmail system preference becomes system preference ILLDefaultStaffEmail. Can we modify the tt so that we get the whole sentence, or a %s that we can play with to change the order of the words? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation : Ability to |Translation: Ability to |change the sentence |change the sentence |structure in branches.tt |structure in branches.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145112&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation: Ability to |Translation: Ability to |change the sentence |change the sentence |structure in branches.tt |structure on library | |administration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145112|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145113&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_... https://bugs.koha-community.org/show_bug.cgi?id=31954 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30993 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Katrin! Thanks for looking at this one! I tested and it works well. However, it does add unnecessary strings in the .po file, such as #. %1$s: IF ( CAN_user_parameters_manage_sysprefs ) #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt:194 #, fuzzy, c-format msgid "%s [%% SET pref_ILLDefaultStaffEmail_link = '" msgstr "%s %s [%% SET pref_MARCOverlayRules_link = '" (ignore the msgstr, i's obviously wrong hehe!) I tried to remove the patch and reupdate the files and these lines disappear, so it's definitely the patch that adds them. I tried adding spans to indicate the limits of the translatable string, but it doesn't remove the SET blabla lines from the po file. Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I saw these extra strings, but I am not sure if we can avoid them. You might have to pick your poison... I copied this solution from something Jonathan did for Curbside pickups, not sure if there is any other way right now. And this one is not from this patch set: msgstr "%s %s [%% SET pref_MARCOverlayRules_link = '" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I can't find the bug, but I'm pretty sure Frido did something to remove TT comments from translatable strings in one bug I had... I found bug 18682 but it's not the same I remember. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #5)
I can't find the bug, but I'm pretty sure Frido did something to remove TT comments from translatable strings in one bug I had...
I found bug 18682 but it's not the same I remember.
Good thinking, maybe Frido can help! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145161&action=edit Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145113|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145162&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_... https://bugs.koha-community.org/show_bug.cgi?id=31954 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145161|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145163&action=edit Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145162|0 |1 is obsolete| | --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 145164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145164&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_... https://bugs.koha-community.org/show_bug.cgi?id=31954 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145163|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 145165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145165&action=edit Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145164|0 |1 is obsolete| | Attachment #145165|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146513&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_... https://bugs.koha-community.org/show_bug.cgi?id=31954 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146514&action=edit Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 146688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146688&action=edit Bug 31957: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.11 released in| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|23.05.00,22.11.03,22.05.11 |23.05.00,22.11.03,22.05.11, released in| |21.11.19 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for upcoming 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED --- Comment #19 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org