[Bug 36949] New: Cataloguing error links don't scroll to correct position when tab changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36949 Bug ID: 36949 Summary: Cataloguing error links don't scroll to correct position when tab changes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: trainee@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 167113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167113&action=edit Screenshot of the error message links on cataloguing/addbiblio.pl During cataloging if there are errors in the marc fields when trying to save a record, the error links don't always scroll to the correct field position. This happens when the link directs to an inactive tab and has to scroll over many fields. (Earlier the tab change was also broken but got fixed in 23.11.) Prerequisites for testing: 1. Make sure there are enough editable fields in the biblio framework you'll use for testing to require plenty of scrolling. 2. Make sure that there are enough required fields in the biblio framework to trigger error messages and getting to these fields requires scrolling. Testing: 1. Go to cataloging and Add record. 2. Try to save the record without filling in the required fields. 3. Click -> Go to field link that directs to an inactive tab. 4. Note that while the tab changes correctly, the window doesn't quite scroll far enough to the correct field. 5. Try also clicking the link to an active tab, and note that scrolling works fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36949 Katariina Pohto <trainee@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |trainee@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Katariina Pohto <trainee@koha-suomi.fi> --- Created attachment 167116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167116&action=edit Bug 36949: Cataloguing error links don't scroll to correct position when tab changes This patch adds a small delay between tab change and finding the new coordinates, and seems to fix the issue. It might not be the best fix for this but it should show that problem most likely lies with the tab change reorganizing the page, and the coordinates misfiring because the page-loading is not done immediately. Test plan: 1. Reproduce the bug by following the plan on 1st post 2. Apply patch and clear cache 3. Go back and try again to save a new biblio without required information 4. Click an error link that directs to inactive tab, and previously didn't scroll to the correct position 5. Note that the window now scrolls to the correct position -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I had a go at testing using koha-testing-docker (KTD) on main, but I couldn't replicate the issue. I tried with several browsers, with the cache cleared (Firefox Developer Edition, Chromium, and Google Chrome). I also tried using UNIMARC, mainly as it has a lot of mandatory fields and lots of tags and subfields in most sections. In all cases, it scrolled down to the field with the error for active and inactive sections. I'll leave to see if anyone else can replicate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36949 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |Laura.escamilla@bywatersolu | |tions.com Resolution|--- |WORKSFORME --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I have also tested this in several browsers and have not been able to recreate the bug. In all cases, as David mentioned, clicking on the 'Go to field' properly scrolled down to the field with the error for active and inactive sections. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org