[Bug 8534] New: Remove unused variable from memberentry template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Priority: P5 - low Change sponsored?: --- Bug ID: 8534 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Remove unused variable from memberentry template Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha The variable nobranchcode is used in an UNLESS statement in memberentry.tt. It exists nowhere else in the codebase, and is thus superfluous. Somehow, despite the fact that is never referenced anywhere else in the code base, it is getting set to '1' for one of our libraries. This means they cannot add patrons, due to the submitted data lacking a patron branchcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11218&action=edit Bug 8534 - Remove unused variable from memberentry template The variable nobranchcode is used in an UNLESS statement in memberentry.tt. It exists nowhere else in the codebase, and is thus superfluous. This patch removes this unnecessary code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #0)
Somehow, despite the fact that is never referenced anywhere else in the code base, it is getting set to '1' for one of our libraries. This means they cannot add patrons, due to the submitted data lacking a patron branchcode.
It seems to me that removing the conditional is the wrong solution. The nobranchcode variable demonstratively *is* being set, if you're running into problems, so the actual cause of the problem should be located, and the underlying logic issue fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Take a look around lines 108-112 of memberentry.pl. You will want to change the syspref BorrowerUnwantedField to not include "branchcode" for that library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Thanks for the additional information. I missed that and grepping of course did not reveal that code. Koha has foreign key constraints that causes adding a borrower without a branchcode to fail. Is there a valid use-case for keeping this bit of code in Koha? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- I reset the status to ASSIGNED, as the actual patch cannot be signed-off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #5)
I reset the status to ASSIGNED, as the actual patch cannot be signed-off.
I'm not sure shat you mean by this. Why do you think the actual patch cannot be signed-off? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if you have only one branch you could autofill the branch value and that might be a reason to hide it. I think signing off the patch would make the feature inconsistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org