[Bug 36488] New: Flatpickr creates invalid date entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Bug ID: 36488 Summary: Flatpickr creates invalid date entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I believe that in some conditions flatpickr creates invalid date entries that can be saved. To test: * Switch DateFormat to DD.MM.YYY * Go to the OPAC self registration form * Enter a date of 00.00.000 * It will show as: 30.12.00-1 in the input and can be saved We have seen something similar on bug 36466. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36466 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This breaks patron search and is nothing the library can fix themselves, it needs to be fixed within the database. Upping severity. It's also happening quite frequently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Confirmed on main? I don't recreate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- It inserted "0001-01-01" and search is not broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #3)
It inserted "0001-01-01" and search is not broken.
We end up with 0000-00-00 in these cases in dateofbirth. It happens in 22.11.16 reliably. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have tried to find a way to replicate the issue, we are not sure what exactly the people registering are entering to cause the date, but it has happened at least 3 times now on different servers/instances. We are using the DD.MM.YYYY DateFormat - not sure if that could make a difference? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- On 22.11.16, Using "00000000" make fp displays "30.12.00-1", save and get: Invalid value passed, borrowers.dateofbirth=00-1-12-30 expected type is date at /usr/share/perl5/Exception/Class/Base.pm line 88 So I guess it depends on the DBMS version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Sounds like a duplicate of bug 27768. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Maybe bug 33703 is causing the behaviour difference between main and 22.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, more to investigate. We are currently updating to a newer Debian version which should also include a newer version of MariaDB. Maybe this will make a difference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 37142 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This regularly kills patron search in our installation using self registration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- I have tried, without success, to recreate this on the OPAC self reg page in main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, I think we are missing something either in configuration or setup (DBMS version) that causes this :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Lowering severity as we have trouble to replicate the problem. Please provide more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27768 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We've had at least 5 cases from different libraries on different servers running 22.11 so far. I think we need to keep trying to replicate as this is a real issue. Also other reports on mailing list/Mattermost about invalid dates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #16 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- I couldn't manage to enter an invalid date in a sandbox (24.06.00) either. But i was able to in our test-environment in 22.11. You can type in the date with zero's - in our case in the date-format DD.MM.YYYY. So it was 00.00.0000. It wasn't possible to do that in 24.06. I don't know if there's another way to enter the invalid date. But this way - typing in - was doable in 22.11. I have tested that in Firefox and Edge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |22.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35957 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |CONFIRMED --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if this needs to be in Discussion, 22.11 is still maintained and we have an error, that can be reproduced. I think the difference might be DBMS version or similar, but it would be good to get some more eyes on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #17)
I am not sure if this needs to be in Discussion, 22.11 is still maintained and we have an error, that can be reproduced. I think the difference might be DBMS version or similar, but it would be good to get some more eyes on this.
The comments make it seem like it can't be reproduced? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I need to find time to test this with the strict SQL mode disabled in a development environment, I suspect that could be it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We just confirmed: the difference is the strict sql mode. In 24.11 in ktd and package installations it's not possible to enter a false date. Entering more than one zero is blocked. In 22.11.23 it's possible in package installations with DateFormat DD.MM.YYYY to enter 00.00.0000 and it will store a false date. So ktd: DateFormat: ktd default * We checked out 22.11.x and reset the database. * Date of birth now allows to enter more than one zero. * Enter 8 zeros: 00000000 and click outside the field. * Date is shown as: 11/30/00-1 * On saving we get an error: Invalid value passed, borrowers.dateofbirth=00-1-11-30 expected type is date. BUT: the problem occurs without strict_sql_mode: * Deactivated strict_sql_mode in koha-conf.xml * Repeat steps: now you can save the user with the date shown as 11/30/00-1. * SELECT dateofbirth, borrowernumber from borrowers; * Newest entry shows the wrong date 0000-00-00. Updated to latest 23.05: * Wrong date can be entered and is stored. Updated to latest 23.11: * Wrong date can be entered and is stored. Updated to latest 24.05: * Fixed: it's not possible to enter invalid dates anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.blanchard@ptfs-eu | |rope.com, | |chloe.zermatten@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Hackfest -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36488 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org