[Bug 36864] New: Bug 30579 follow-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Bug ID: 36864 Summary: Bug 30579 follow-up Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 30579 did some things to make the hold request page easier to navigate. Great improvements. There was a couple small things I'd like to address: 1. You can click on the disabled fieldset select2 dropdowns. 2. Invalid HTML. Inputs cannot be children of an HTML button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166743&action=edit Bug 36864: Add classes/CSS/fix markup on request.tt To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Place a hold 4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default. 5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to. 6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns. 7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 [Bug 30579] When placing item level hold, some options that are not used are not disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166744&action=edit Bug 36864: Add a font awesome icon to indicate enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166743|0 |1 is obsolete| | Attachment #166744|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166768&action=edit Bug 36864: Add classes/CSS/fix markup on request.tt To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Place a hold 4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default. 5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to. 6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns. 7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166769&action=edit Bug 36864: Add a font awesome icon to indicate enabled Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Very nice! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we make the bug description a bit more descriptive please? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 30579 follow-up |Further improvements to | |holds request page CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166768|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166778&action=edit Bug 36864: Add classes/CSS/fix markup on request.tt To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Place a hold 4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default. 5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to. 6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns. 7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166769|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166779&action=edit Bug 36864: Add a font awesome icon to indicate enabled Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, works as designed. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's a visual improvement, but I feel people will still think they need to click into the rather small radio boxes instead of clicking on the label that is a much nicer click target. I wish we could improve on that in another bug maybe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
I think it's a visual improvement, but I feel people will still think they need to click into the rather small radio boxes instead of clicking on the label that is a much nicer click target. I wish we could improve on that in another bug maybe.
I agree. So I filed Bug 36899: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 [Bug 36899] Further improvements to holds request page, part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This is part of release notes| |improvements to placing | |holds from the record page | |in the staff interface. | | | |It | |adds a tick icon with a | |green background to the | |section selected (either | |'Hold next available item' | |or 'Hold a specific item'). | | | |It prevents selecting drop | |down lists in the section | |not selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 30579 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Bug 36864 depends on bug 30579, which changed state. Bug 30579 Summary: When placing item level hold, some options that are not used are not disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 Bug 36864 depends on bug 30579, which changed state. Bug 30579 Summary: When placing item level hold, some options that are not used are not disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org