[Bug 4036] New: Two conditions missing from circ template messages: USERBLOCKEDOVERDUE and USERBLOCKEDREMAINING
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Summary: Two conditions missing from circ template messages: USERBLOCKEDOVERDUE and USERBLOCKEDREMAINING Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Circulation AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org Estimated Hours: 0.0 Change sponsored?: ---
From Circulation.pm:
my ($blocktype, $count) = C4::Members::IsMemberBlocked($borrower->{'borrowernumber'}); if($blocktype == -1){ ## remaining overdue documents $issuingimpossible{USERBLOCKEDREMAINING} = $count; }elsif($blocktype == 1){ ## blocked because of overdue return $issuingimpossible{USERBLOCKEDOVERDUE} = $count; } There is no conditional markup for these states in circulation.tmpl, so if these conditions are triggered the circ template displays an yellow alert box with no content. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henridamien@koha-fr.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-01-11 16:19:46 --- In the relevant portion of Members.pm (line 572): my $sth = $dbh->prepare( "SELECT COUNT(*) as latedocs FROM issues WHERE borrowernumber = ? AND date_due < now()" ); If I try a similar query: mysql> select date_due,returndate,issuedate from issues WHERE borrowernumber = 51 and date_due < now(); +------------+------------+------------+ | date_due | returndate | issuedate | +------------+------------+------------+ | 2010-01-11 | NULL | 2009-12-28 | | 2010-01-11 | NULL | 2009-12-28 | | 2010-01-11 | NULL | 2009-12-28 | | 2010-01-11 | NULL | 2009-12-28 | | 2010-01-11 | NULL | 2009-12-28 | | 2010-01-11 | NULL | 2009-12-28 | +------------+------------+------------+ Is it correct that IsMemberBlocked() should return -1 if my checkouts are due today? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |henridamien@koha-fr.org Severity|critical |blocker -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-02-08 09:14:22 --- Created an attachment (id=1570) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1570) screenshot -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-02-08 09:14:46 --- This is still a problem in 3.01.00.111 (patched from 3.01.61) I am testing notices on our production server and test installation of 3.2. To compare the results, I use the same test cases and configuration. Today I wanted to check out another book to a patron, who has already checked out one item with due date today. In 3.01.61 I get no error message at all, in HEAD I get an empty yellow error box so that I can not check out to this patron. I think it should warn the day after due date with a yes/no option for check out. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 hdlaurent <henridamien@koha-fr.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 hdlaurent <henridamien@koha-fr.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |nahuel.angelinetti@biblibre. | |com Status|ASSIGNED |NEW -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #4 from hdlaurent <henridamien@koha-fr.org> 2010-02-10 13:42:55 --- We should port the work done by BibLibre on finedays on 3.2 -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> 2010-02-10 14:41:34 --- (In reply to comment #4)
We should port the work done by BibLibre on finedays on 3.2
Is the work in question in 3.0.x? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2010-02-25 13:47:53 --- Same problem in 3.0.x? http://lists.katipo.co.nz/pipermail/koha/2010-February/022742.html -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> 2010-02-25 15:29:00 --- Following up on comment by Cynthia Murdock, there should be a setting to allow USERBLOCKEDOVERDUE to be overridable; not all libraries forbid loaning to patrons who have overdue loans. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> 2010-02-25 15:29:55 --- S(In reply to comment #7)
Following up on comment by Cynthia Murdock, there should be a setting to allow USERBLOCKEDOVERDUE to be overridable; not all libraries forbid loaning to patrons who have overdue loans.
Sorry, completely borked the name - suggestion was from Cindy Murdock Ames. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> 2010-02-25 15:31:56 --- Was that really the intent, that users be blocked for ANY overdues? We could really use some feedback on this issue. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-02-25 15:38:23 --- In my tests the items were not even overdue, they were just due. (Block starts on date of due date) -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Cindy Murdock <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock@ccfls.org -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Kyle Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nahuel.angelinetti@biblibre.|kyle.m.hall@gmail.com |com | Status|NEW |ASSIGNED --- Comment #11 from Kyle Hall <kyle.m.hall@gmail.com> 2010-03-03 15:21:08 --- Created an attachment (id=1727) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1727) Bugfix patch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #12 from Kyle Hall <kyle.m.hall@gmail.com> 2010-03-03 15:21:37 --- Created an attachment (id=1728) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1728) Bugfix patch - Database Update -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Nahuel Angelinetti <nahuel.angelinetti@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nahuel.angelinetti@biblibre. | |com --- Comment #13 from Nahuel Angelinetti <nahuel.angelinetti@biblibre.com> 2010-03-03 15:41:23 --- Hi, We did another bugfix style, as we expect, an issues must be refused ONLY if there is an error during issuing. If there is a quota problem, or overdues or anything else, koha should ever ask librarian if he want to override or not the quota restriction. We think all librarians are able to do this choice. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2010-04-26 08:10:28 --- There is a patch for bug 4405, that implements a systempreference to control this behaviour. If that is accepted, this bug could be closed -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> 2010-05-01 15:05:10 --- Pushed patch for related bug 4405. Will apply parts of Kyle's patch to round out messages. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kyle.m.hall@gmail.com |gmcharlt@gmail.com Status|ASSIGNED |NEW -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> 2010-05-01 16:52:59 --- Submitted patches to deal with the following issues: * fix wording per Kyle's suggetions * don't count items due today as being overdue * allow accrued fine days to be reported even if library permits loans to patron who have current overdue items * fix swap of USERBLOCKEDOVERDUE and USERBLOCKEDREMAINING blocks -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> 2010-05-03 11:47:27 --- Pushed patches. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4036 Cookie Wolfrom <cookie.wolfrom@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com