[Bug 21234] New: Remove our .clearfix class in favor of Bootstrap's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Bug ID: 21234 Summary: Remove our .clearfix class in favor of Bootstrap's Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Bootstrap in the staff client has its own ".clearfix" class which appears to be conflicting with the one in staff-global.scss. Removing .clearfix from staff-global.scss fixes it. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740#c2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77922&action=edit Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77922|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77976&action=edit Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21239 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 [Bug 21239] CSS regressions caused by SCSS move -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77976|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 78047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78047&action=edit Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 19474 not in 18.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org