[Bug 12549] New: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Bug ID: 12549 Summary: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: vanoudt@gmail.com QA Contact: testopia@bugs.koha-community.org In Koha-conf.xml, the font paths for the DejaVu fonts are hardcoded. Unfortunately, the paths don't match the installed font locations in other distributions (such as Fedora). Ideally, the system should enquire of fontconfig where the fonts are installed. Something like: fc-list : file | grep Deja spits out the correct paths, and should work across distributions. Just spent quite a long time trying to figure out why the Creators.t test was continually failing during make test even though they ran fine manually. Problem seems to have been this! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 --- Comment #1 from Nicholas van Oudtshoorn <vanoudt@gmail.com> --- It's not in perl, but the following bash snippet (hacky, but works!) could set the proper paths... #!/bin/bash tr=$(fc-list : file | grep DejaVuSerif.ttf) tb=$(fc-list : file | grep DejaVuSerif-Bold.ttf) ti=$(fc-list : file | grep DejaVuSerif-Italic.ttf) tbi=$(fc-list : file | grep DejaVuSerif-BoldItalic.ttf) c=$(fc-list : file | grep DejaVuSansMono.ttf) cb=$(fc-list : file | grep DejaVuSansMono-Bold.ttf) co=$(fc-list : file | grep DejaVuSansMono-Oblique.ttf) cbo=$(fc-list : file | grep DejaVuSansMono-BoldOblique.ttf) h=$(fc-list : file | grep DejaVuSans.ttf) ho=$(fc-list : file | grep DejaVuSans-Oblique.ttf) hb=$(fc-list : file | grep DejaVuSans-Bold.ttf) hbo=$(fc-list : file | grep DejaVuSans-BoldOblique.ttf) echo "<font type=\"TR\" >${tr%??}</font>" echo "<font type=\"TB\" >${tb%??}</font>" echo "<font type=\"TI\" >${ti%??}</font>" echo "<font type=\"TBI\" >${tbi%??}</font>" echo "<font type=\"C\" >${c%??}</font>" echo "<font type=\"CB\" >${cb%??}</font>" echo "<font type=\"CO\" >${co%??}</font>" echo "<font type=\"CBO\" >${cbo%??}</font>" echo "<font type=\"H\" >${h%??}</font>" echo "<font type=\"HO\" >${ho%??}</font>" echo "<font type=\"HB\" >${hb%??}</font>" echo "<font type=\"HBO\" >${hbo%??}</font>" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Nicholas van Oudtshoorn <vanoudt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |vanoudt@gmail.com Status|NEW |Needs Signoff --- Comment #2 from Nicholas van Oudtshoorn <vanoudt@gmail.com> --- Created attachment 45897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45897&action=edit Allows selecting the path for fonts at installation time Allows for selection of DejaVu font path when installing from the command line. This is useful for non-debian distributions that don't store the fonts in the same place. Adds a new configuration variable to Makefile.PL: FONT_DIR Defaults to the Debian install location for the fonts. Test plan: 1. Run a CLI install, accepting the defaults. 2. Compare the generated koha-conf.xml to a previous install - the font path for DejaVu fonts should be the same. 3. Run another CLI install, this time choosing a custom path for the fonts 4. Check that the path selected is reflected in the koha-conf.xml file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Nicholas van Oudtshoorn <vanoudt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.16 |master Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Federico <federicoleva@tiscali.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federicoleva@tiscali.it -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org