[Bug 6413] New: Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Bug #: 6413 Summary: Notes in Fines doing wonky things Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Follow these steps: Add a manual invoice with a note Add a second manual invoice with a different note Pay the first invoice using the 'pay' tab the note carries over but is not published on the 'pay' line Pay the second invoice and put a different note in the note isn't put on the payment line, but the note on the charge is changed Logically, there should be a note for the payment line and a note for the charge line, they don't have to be the same. As it is now you can't add a note on a payment line at all, but the field is there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-05-26 19:10:22 UTC --- Example video: http://screencast.com/t/bPYEhgtAj -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-05 01:34:52 UTC --- Looking into this -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-05 01:44:20 UTC --- Its working as designed, it allows you to modify the note on the charge when you save. It was never designed to add a new note on the payment line. So changing it would be changing behaviour, which would make it impossible for libraries to change the note on a charge when the pay it off. Is that desirable? I think it would have to be done in a way that allows current behaviour to still continue, but also allow someone to add a note on the payment line. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-09-07 16:56:18 UTC --- I honestly don't know. It sounds like if that's how it's supposed to be then maybe we shouldn't consider what I'm asking for a bug. Instead this is a feature request to be able to add a note to payments that is separate from the fine line. Anyone else have any opinions? Maybe a way to make this clearer to the librarian what's going to happen because it looks like the note is going on the payment line because that's where the form is appearing. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #5 from Chris Hall <chrish@catalyst.net.nz> 2012-01-06 02:16:53 UTC --- The ability to add a note when paying a fine appears to have been removed in the patch for bug 3498 Allow partial payments of fines (507c7f422485aaf7ae601b0a84bacdbaedac061c). Is adding it back in desirable? If so, is the ability to also edit the notes on fines still required? Currently it is not possible so not having it is not reverting, however it could be added in via an edit button on the fines page or something similar. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2012-01-06 13:47:44 UTC --- I've had several libraries ask to have that ability brought back - for paying and for writing off fines. I'm not sure about whether they want to be able to edit that note after the fact, but if it were possible I'm sure no one would complain. Most important thing is allowing people to make notes/memos on payments/writeoffs. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff AssignedTo|kyle.m.hall@gmail.com |chrish@catalyst.net.nz --- Comment #7 from Chris Hall <chrish@catalyst.net.nz> 2012-01-26 03:24:54 UTC --- Created attachment 7333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7333 Added ability to add notes when paying or writing off fines On the Account tab of the fines page there is a new 'note' column beside each entry. When paying a fine a 'payment note' box appears beside each fine, this note will be set for that payment rather than the fine itself. Both notes on fines and notes on payments/write-offs cannot be changed. Using either the 'pay' or 'write off' buttons next to an entry will save the note for that entry. Using the 'writeoff all' button will save the notes for all entries. Please note however that using either the 'pay amount' or 'pay selected' does NOT save the notes. This is due to the current way in which this is handled between pay.pl and paycollect.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-06 20:33:28 UTC --- Attempted testing of this patch, does not appear to work completely. Applies cleanly. 1) I created a series of manual invoices with notes, those notes appear in the Note column on boraccount.pl 2) Switch to pay.pl. Here, the Payment Note column appears with a text box, but does not pull over the fine note ( I'm not sure if that is supposed to be part of the functionality or not, but I thought I'd mention it ). 4) Tested with pay, writeoff, and writeoff all buttons, works as stated. HOWEVER, everything gets broken and messed up if special characters are used in *any* of the notes fields. The data being passed is not being url encoded properly. For example, if I make the payment note "Test Payment #12 Note", the payment note will be "Test Payment ". It gets truncated at the special character. If you look at the passed params, you will see "payment_note=Test Payment #12 Note" rather than "payment_note=Test%20Payment%20%2312%20Note", as it should be. It gets worse if you used special characters in the Description of charges, or the Note field. In that case, no part of the note will show up, as everything is truncated at the special character even earlier. So, patch essentially works, but everything needs to be url encoded properly or librarians will not understand why their notes aren't showing up correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7333|0 |1 is obsolete| | --- Comment #9 from Chris Hall <chrish@catalyst.net.nz> 2012-02-08 01:17:09 UTC --- Created attachment 7496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7496 Added ability to add notes when paying or writing off fines Cheers for that Kyle. There was 2 issues. One was with the note fields for payments needing url encoding, the other was to do with description$line_no needing to be escaped, but as I cant see where it is being used I have removed it (if it needs to be put back in, it must be uri_escaped). Hope this patch works better. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-15 13:33:04 UTC --- Applying: Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments /home/koha/kohaclone/.git/rebase-apply/patch:77: trailing whitespace. <th>Payment Note</th> /home/koha/kohaclone/.git/rebase-apply/patch:217: trailing whitespace. if ( $total_paid == $total_due ) { error: patch failed: C4/Accounts.pm:197 error: C4/Accounts.pm: patch does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7496|0 |1 is obsolete| | --- Comment #11 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 9107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9107&action=edit Added ability to add notes when paying or writing off fines Corrected patch so it would apply against master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- nengard@kohavm:~/kohaclone$ git bz apply 6413 Bug 6413 - Notes in Fines doing wonky things Added ability to add notes when paying or writing off fines Apply? [yn] y Applying: Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments /home/nengard/kohaclone/.git/rebase-apply/patch:121: trailing whitespace. <th>Payment Note</th> /home/nengard/kohaclone/.git/rebase-apply/patch:231: trailing whitespace. if ( $total_paid == $total_due ) { error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt:47 error: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt: patch does not apply Patch failed at 0001 Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Added-ability-to-add-notes-when-paying-or-writing--sDFuBJ.patch nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Did you remember to try applying it with a 3 way merge git bz is cool, but without the patch from paul, it doesnt try to merge. git am --abort git am -iu3 /tmp/Added-ability-to-add-notes-when-paying-or-writing--E9jlEe.patch Found out it was a tiny conflict because of the capitalisation change, in one file. Fixed that, reattached. But if git bz fails, please try git am -iu3 before marking does not apply, if that still fails, then that's fine. But a lot of the times it passes -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9107|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9129&action=edit Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9129|0 |1 is obsolete| | --- Comment #15 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9144&action=edit [SIGNED-OFF] Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Paid full fines, partial fines and wrote off fines - all with notes everything worked as expected. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- A future dev for this would be to allow notes when using the buttons at the bottom .. but this works as explained and is a great step in the right direction! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #17 from Ian Walls <koha.sekjal@gmail.com> --- Adds payment_note param to makepayment(), makepartialpayment() and WriteOffFee(). Additional param is at the end, and is safely added (defined to '' if nothing is passed) Introduces a new string to members/pay.tt... RM, your call as to whether that's a blocker for 3.8 or not. Otherwise, looks good, marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9144|0 |1 is obsolete| | --- Comment #18 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 9220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9220&action=edit Added ability to add notes when paying or writing off fines I noticed that somehow a typo got merged into my patch that wasn't in my original version (if you look at the latest patch before mine it says "Account ype" whereas my patch says "Account Type"). Should apply cleanly against master (also fixed white space issue). Sorry to make you guys sign off again. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9220|0 |1 is obsolete| | --- Comment #19 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9221&action=edit [SIGNED-OFF] Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #20 from Nicole C. Engard <nengard@gmail.com> --- signed off on typo fix. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- This patch changes some string, so i'm not inclined to push it for 3.8, plus there's a (tiny) failed QA problem: Payment Note => should be Payment note. I continue checking other patches that passed QA, will decide later if it's better to push it -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- (note that "Payment note" string does not exist yet in the translation tables, so it won't be translated if I push) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: if you use the 'pay amount' button, any comment you've entered is lost. I think this is quite inconsistent. Any explanation welcomed, maybe that's an ergonomic problem (mixing pay line by line, with comment added, and pay all at once is illogic) Marking failed QA for now, not that I refuse the patch, but fixes a problem and I think introduces another one... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #24 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 9374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9374&action=edit Bug 6413 follow-up: fixing capital case & tabs * switching from "Payment Note" to "Payment note" * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #25 from Nicole C. Engard <nengard@gmail.com> --- I agree that when paying all or paying selected the notes should stay - but it's not a new bug as much as it's a feature that never existed. So I'd love to see that feature added :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #26 from Chris Hall <chrish@catalyst.net.nz> --- Hey Guys I agree that all the buttons should behave in a similar way and that this could be confusing. However for both pay amount and pay selected the way they are handled is quite differently to the other buttons, everything (either everything selected or everything) in the form is encoded into a one dimensional array that is then encoded as a single string and this is then passed back and forth between multiple scripts. This is quite messy to deal with and get right and would significantly increase the size and complexity of the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #27 from Nicole C. Engard <nengard@gmail.com> --- Like I said, I'm with Chris, I don't think this should fail QA. The reason you're failing it is a feature that never existed, Chris's patch just fixes a feature that did exist and was broken. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #13)
Did you remember to try applying it with a 3 way merge
git bz is cool, but without the patch from paul, it doesnt try to merge.
Just as a reminder, the patch is here: https://depot.biblibre.com/ppoulain/0001-Add-3-parameter-to-git-am.patch (otherwise, checking this patch again, to see if I was wrong refusing QA, or arguing a little bit more to justify) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- After testing again, I confirm my failed QA: * add 2 manual invoices, say 1€ and 2€ * head to "Pay fine" (pay.pl) tab * you can: - check or uncheck a line - add a comment on each line * uncheck line 2€, keep line 1€ checked, add a note to line 1€ * clic "Pay selected": you are asked to pay 1€, if you save,the comment you've entered is not saved I also tried to reproduce the behaviour shown on http://screencast.com/t/bPYEhgtAj, but since the bug 3498 Allow partial payments of fines, things have changed, and I can't reproduce the buggy behaviour. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 7004 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #31 from Nicole C. Engard <nengard@gmail.com> --- Chris, Can you submit a new patch that will pass QA on this? Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |wizzyrea@gmail.com --- Comment #32 from Liz Rea <wizzyrea@gmail.com> --- This patch no longer applies :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8776 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12658&action=edit Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9221|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12658|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12661&action=edit Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #35 from Mason James <mtj@kohaaloha.com> --- Created attachment 12668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12668&action=edit Bug 6413 follow-up: fixing capital case & tabs * switching from "Payment Note" to "Payment note" * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12661|0 |1 is obsolete| | --- Comment #36 from Mason James <mtj@kohaaloha.com> --- Created attachment 12669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12669&action=edit Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12668|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | --- Comment #37 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #36)
Created attachment 12669 [details] Bug 6413 Added ability to add a note when paying or writing off a fine
Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
2 patches test as expected, passing QA... $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 6c18204) * c1c9900 Bug 6413 follow-up: fixing capital case & tabs koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt * 66cfbba Bug 6413 Added ability to add a note when paying or writing off a fine C4/Accounts.pm koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt members/pay.pl members/paycollect.pl * C4/Accounts.pm OK * members/pay.pl OK * members/paycollect.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> --- Sorry guys (& girls), but the problem I've explained in comment 29 is still here: (In reply to comment #29)
After testing again, I confirm my failed QA: * add 2 manual invoices, say 1€ and 2€ * head to "Pay fine" (pay.pl) tab * you can: - check or uncheck a line - add a comment on each line * uncheck line 2€, keep line 1€ checked, add a note to line 1€ * clic "Pay selected": you are asked to pay 1€, if you save,the comment you've entered is not saved
I also see wrong HTML: + <td><input type="text" name="payment_note_[% line.accountno %]"></input></td> should be written <td><input type="text" name="payment_note_[% line.accountno %]" /></td> (self closed html tag) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #39 from Melia Meggs <melia@bywatersolutions.com> --- Just a nudge - is anyone working on a new patch that addresses Paul's QA comments, by chance? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #40 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #39)
Just a nudge - is anyone working on a new patch that addresses Paul's QA comments, by chance?
seems no... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12669|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14832&action=edit [SIGNED-OFF] Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14833&action=edit Bug 6413 - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Is this what you were asking for? ^ (In reply to comment #40)
(In reply to comment #39)
Just a nudge - is anyone working on a new patch that addresses Paul's QA comments, by chance?
seems no...
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9374|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14834&action=edit Bug 6413 follow-up: fixing capital case & tabs * switching from "Payment Note" to "Payment note" * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Followup is super trivial, switching to signed-off. QA can decide if another SO is necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14840&action=edit Bug 6413 - QA Followup - Add notes for 'Pay selected' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14840|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14846&action=edit Bug 6413 - QA Followup - Add notes for 'Pay selected' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Can someone provide a test plan for this? Can the last three patches be squashed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Also, is the title of this bug accurate with regard to what the patches are for? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14834|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14895&action=edit [SIGNED-OFF] Bug 6413 follow-up: fixing capital case & tabs * switching from "Payment Note" to "Payment note" * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14833|0 |1 is obsolete| | Attachment #14846|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14896&action=edit Bug 6413 - QA Followup - Add notes for 'Pay selected' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #49)
Also, is the title of this bug accurate with regard to what the patches are for?
The middle one is from Paul, but I squashed my two together. Nicole mentioned the lack of the note field in her initial comment, but it might be better to change the title to something like "Add note fields for fine payments". Test plan: 1) Apply the patches 2) Create some test fees 3) Pick two or more to use for the 'Pay selected' option, add notes for each 4) Click 'pay selected' 5) The notes for each selected fee should be pulled into the new 'notes' text field on paycollect.pl. Here you can modify the imported notes if you wish before clicking "Confirm" 6) Confirm the note for the payment is now displayed on boraccount.pl for the payment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- I'm ready to sign off except for one small bug: The table columns are now out of sync with the footer. Sub total and total due should be aligned with the last column. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14896|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14899&action=edit Bug 6413 - QA Followup - Add notes for 'Pay selected' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Fixed! (In reply to comment #53)
I'm ready to sign off except for one small bug: The table columns are now out of sync with the footer. Sub total and total due should be aligned with the last column.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14899|0 |1 is obsolete| | --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14900&action=edit [SIGNED-OFF] Bug 6413 - QA Followup - Add notes for 'Pay selected' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch conflicts now because the fix for recording payments in the logs. Kyle or Chris - can you please resolve the conflicts? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14832|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15232&action=edit Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14895|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15233&action=edit Bug 6413 follow-up: fixing capital case & tabs * switching from "Payment Note" to "Payment note" * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14900|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15234&action=edit Bug 6413 - QA Followup - Add notes for 'Pay selected' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|mtj@kohaaloha.com |paul.poulain@biblibre.com --- Comment #61 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : * small conflict i've fixed * still passes koha-qa * the bugguy behaviour I saw in comment 29 is fixed * no other comment passed QA ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15232|0 |1 is obsolete| | Attachment #15233|0 |1 is obsolete| | Attachment #15234|0 |1 is obsolete| | --- Comment #62 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16486&action=edit [PASSED QA]Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16486|0 |1 is obsolete| | --- Comment #63 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16487&action=edit [PASSED QA]Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #64 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16488&action=edit [PASSED QA]Bug 6413 follow-up: fixing capital case & tabs * switching from "Payment Note" to "Payment note" * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #65 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16489&action=edit [PASSED QA]Bug 6413 - QA Followup - Add notes for 'Pay selected' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #66 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch breaks the table on the Pay fines tab: http://screencast.com/t/YgcrEjHqBCU -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chrish@catalyst.net.nz |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18035&action=edit Bug 6413 - QA Followup - Remove extra table column header Trivial fix, switching back to passed qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #68 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has string changes and will therefore be held for 3.14. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #69 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Chris, Paul, and Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org