[Bug 26462] New: t/db_dependent/Holds.t holds_per_day tests delete data unnecessarily
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Bug ID: 26462 Summary: t/db_dependent/Holds.t holds_per_day tests delete data unnecessarily Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org While testing on a larger database I noticed that the CanItemBeReserved / holds_per_day tests were hanging. It appears this is because they delete all holds, issues, items, biblios, and circulation rules. The tests generate their own itemtype, rules, patrons, and libraries. There is no need to delete the existing data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t/db_dependent/Holds.t |t/db_dependent/Holds.t |holds_per_day tests delete |tests delete data |data unnecessarily |unnecessarily -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #0)
While testing on a larger database I noticed that the CanItemBeReserved / holds_per_day tests were hanging. It appears this is because they delete all holds, issues, items, biblios, and circulation rules.
The tests generate their own itemtype, rules, patrons, and libraries. There is no need to delete the existing data.
Following tests in the file follow the same pattern -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 110097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110097&action=edit Bug 26462: Don't delete existing data for tests These tests generate their own items, patrons, and circ rules. Existing system data will not affect the results of the tests. We do not need to delete information. You may be able to notice the difference in speed of tests depending on your system. It should be faster after applying To test: 1 - Before applying patch: prove -v t/db_dependent/Holds.t 2 - It passes 3 - Apply patch 4 - prove -v t/db_dependent/Holds.t 5 - It passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110097|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 110104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110104&action=edit Bug 26462: Don't delete existing data for tests These tests generate their own items, patrons, and circ rules. Existing system data will not affect the results of the tests. We do not need to delete information. You may be able to notice the difference in speed of tests depending on your system. It should be faster after applying To test: 1 - Before applying patch: prove -v t/db_dependent/Holds.t 2 - It passes 3 - Apply patch 4 - prove -v t/db_dependent/Holds.t 5 - It passes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Before patch applied: All tests successful. Files=1, Tests=67, 19 wallclock secs ( 0.04 usr 0.01 sys + 13.94 cusr 1.32 csys = 15.31 CPU) Result: PASS After patch applied: All tests successful. Files=1, Tests=67, 9 wallclock secs ( 0.05 usr 0.01 sys + 7.99 cusr 0.67 csys = 8.72 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110104|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110121&action=edit Bug 26462: Don't delete existing data for tests These tests generate their own items, patrons, and circ rules. Existing system data will not affect the results of the tests. We do not need to delete information. You may be able to notice the difference in speed of tests depending on your system. It should be faster after applying To test: 1 - Before applying patch: prove -v t/db_dependent/Holds.t 2 - It passes 3 - Apply patch 4 - prove -v t/db_dependent/Holds.t 5 - It passes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org