https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40495 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@openfifth.co.uk Assignee|oleonard@myacpl.org |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 200586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200586&action=edit Bug 38198: Add suggestion to BlockExpiredPatronOpacActions syspref This patch adds "suggestion" as an option to BlockExpiredPatronOpacActions, and links that up to the purchase suggestion form. If the syspref is set, and a patron is expired, they will not be able to make a purchase suggestion. == TO TEST == a) create a borrower with no permissions, and an expired card b) log into opac with borrower created in step a c) goto /cgi-bin/koha/opac-suggestions.pl *) note how new purchase suggestion button is visible and works as expected == APPLY PATCH == d) repeat steps b-c *) note how you are greeted with a message *) "Your card has expired, so you are unable to place purchase suggestions" e) goto /cgi-bin/koha/opac-suggestions.pl?op=add_form *) notice how the form is unavailable, and a message displays *) "Your card has expired, so you are unable to place purchase suggestions" == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 --- Comment #2 from Ray Delahunty <raymund.delahunty@outlook.com> --- I've not been all that active in Koha lately as I retired a while back, but I thought this would be an easy one to sign off. Not so. I cannot create an expired patron account in a sandbox. The Yesterday option in the date picker doesn't work, and the previous dates are not visible. (Either when creating a new account, or trying to update an exisiting account). Puzzling. OK, I have set the account to expire today, and should be able to revisit the signoff tomorrow, but am I missing something here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 --- Comment #3 from Ray Delahunty <raymund.delahunty@outlook.com> --- As the intranet will not permit borrowers.dateexpiry to be set to a date prior to borrowers.dateenrolled (as I recall **is** possible via a patron import) this morning I repeated the signoff with an account created (and set to expire) yesterday, and also with an existing patron (created well in the past, after setting its expiry date to yesterday), and the signoff worked just fine. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 --- Comment #4 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 200616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200616&action=edit Bug 38198: Add suggestion to BlockExpiredPatronOpacActions syspref This patch adds "suggestion" as an option to BlockExpiredPatronOpacActions, and links that up to the purchase suggestion form. If the syspref is set, and a patron is expired, they will not be able to make a purchase suggestion. == TO TEST == a) create a borrower with no permissions, and an expired card b) log into opac with borrower created in step a c) goto /cgi-bin/koha/opac-suggestions.pl *) note how new purchase suggestion button is visible and works as expected == APPLY PATCH == d) repeat steps b-c *) note how you are greeted with a message *) "Your card has expired, so you are unable to place purchase suggestions" e) goto /cgi-bin/koha/opac-suggestions.pl?op=add_form *) notice how the form is unavailable, and a message displays *) "Your card has expired, so you are unable to place purchase suggestions" == SIGN OFF == Signed-off-by: Ray Delahunty <Raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 --- Comment #5 from Rhonda Kuiper <rkuiper@roundrocktexas.gov> --- Just trying to give this bug some attention. It has been signed off back in June -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34597 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38198 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | CC| |andrew@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Frido is correct that this needs unit tests. Also, with these patches: Anonymous suggestions via the OPAC fail with a message about undefined category. An un-expired patron is allowed to see the suggestion form on the OPAC, but on submitting the form they get the message "Your card has expired, so you are unable to place purchase suggestions until it has been renewed. Please contact the library if you wish to renew your account." and the suggestion is not created. QA tool complaints: [FAIL] opac/opac-suggestions.pl FAIL critic Variable declared in conditional statement at line 99, column 1. Declare variables outside of the condition. (Severity: 5) [FAIL] Koha/Patron/Category.pm FAIL pod_coverage sub _type has no pod coverage. -- You are receiving this mail because: You are watching all bug changes.