[Bug 20035] New: Switch single-column templates to Bootstrap grid: Patron clubs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Bug ID: 20035 Summary: Switch single-column templates to Bootstrap grid: Patron clubs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 19980 There are two single-column Patron clubs templates which can be updated to use Bootstrap: clubs\clubs-add-modify.tt clubs\templates-add-modify.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70702&action=edit Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs This patch updates two single-column Patron clubs templates to use the Bootstrap grid. - clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club. - clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club template. Also changed in this file: Markup corrections. Label "for" attribute should match the form field's id attribute. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70702|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70848&action=edit Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs This patch updates two single-column Patron clubs templates to use the Bootstrap grid. - clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club. - clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club template. Also changed in this file: Markup corrections. Label "for" attribute should match the form field's id attribute. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70848|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71205&action=edit Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs This patch updates two single-column Patron clubs templates to use the Bootstrap grid. - clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club. - clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club template. Also changed in this file: Markup corrections. Label "for" attribute should match the form field's id attribute. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org