[Bug 14752] New: Add multiple copies to a basket at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Bug ID: 14752 Summary: Add multiple copies to a basket at once Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 46093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46093&action=edit Bug 14752 - Add multiple copies to a basket at once This patch add an 'Add multiple copies' button on the new order page in acquisitions. While processing the multiple copies a modal is displayed. To test: 1 - Add an order to an acquisitions basket 2 - Choose to add multiple items 3 - A modal shouold warn about ignoring UniqueItemFields from syspref 4 - When submitting the modal should popup until all items are processed. 5 - The modal should disappear after items are added. 6 - Items should be cloned, minus unique fields Sponsored by: Middletown Township Public Library (http://www.mtpl.org) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver@bywatersolutions.co |nick@bywatersolutions.com |m | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- I'd suggest using <input type="number"> (like http://www.wufoo.com/html5/types/7-number.html) for the number-of-copies control. It'll add useful UI and make validation easier. I'd also suggest using the humanMsg API for error messages (like Rancor does), though that's more a matter of opinion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 46439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46439&action=edit Bug 14752 - (QA Followup) Use input type="number" and small update to error modal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally <brianagreally@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46093|0 |1 is obsolete| | --- Comment #4 from Briana Greally <brianagreally@gmail.com> --- Created attachment 46832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46832&action=edit Bug 14752 - Add multiple copies to a basket at once This patch add an 'Add multiple copies' button on the new order page in acquisitions. While processing the multiple copies a modal is displayed. To test: 1 - Add an order to an acquisitions basket 2 - Choose to add multiple items 3 - A modal shouold warn about ignoring UniqueItemFields from syspref 4 - When submitting the modal should popup until all items are processed. 5 - The modal should disappear after items are added. 6 - Items should be cloned, minus unique fields Sponsored by: Middletown Township Public Library (http://www.mtpl.org) Signed-off-by: Briana <brianagreally@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally <brianagreally@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally <brianagreally@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46439|0 |1 is obsolete| | --- Comment #5 from Briana Greally <brianagreally@gmail.com> --- Created attachment 46833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46833&action=edit Bug 14752 - (QA Followup) Use input type="number" and small update to error modal Signed-off-by: Briana <brianagreally@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments: 1/ (window.MSG_ADDITEM_JS_UPDATEITEM || "Update item ") If the string is not defined, there is something wrong in the code, we should not provide a hardcoded string 2/ When I click on the "add multiple" button, I get a JS error "TypeError: document.f is undefined" And the behavior if weird: I get the "Invalid number of copies" even if I enter "2", it may come from the JS error. 3/ If I am not wrong, the barcode could be sent, the next one will be generated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47223&action=edit Bug 14752 [QA followup] Remove reference to document.f Remove backup hardcoded string for update item button -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
QA comments: 1/ (window.MSG_ADDITEM_JS_UPDATEITEM || "Update item ") If the string is not defined, there is something wrong in the code, we should not provide a hardcoded string
Fixed! I copied that from existing code and fixed there too
2/ When I click on the "add multiple" button, I get a JS error "TypeError: document.f is undefined" And the behavior if weird: I get the "Invalid number of copies" even if I enter "2", it may come from the JS error.
This was a copy paste error, removed the code. I can't replicate the 'Invalid number' though, hoping fixing the error clears that for you. I checked firefox and chromium on Ubuntu
3/ If I am not wrong, the barcode could be sent, the next one will be generated.
I am not sure what you mean. If barcode is listed in the UniqueItemFields (default) I don't pass barcode into generated records but I do leave it in the form. If it isn't in UniqueItemFields it is passed as is (copied multiple times) and left in the form. It seems tricky because the items are not created until you hit save at the bottom, so incrementing could cause conflicts with autoincrement if others are cataloging at the same time. Thoughts? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, could you double check, I don't get the modal. + <p>Please enter a <b>number</b>, greater than 1</p> I am able to enter 1, without a warning message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47252&action=edit Bug 14752 - [QA Followup] Correct error message Message changed from 'greater than 1' to 'greater than or equal to 1' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
I am able to enter 1, without a warning message.
I think that is the correct behaviour, I altered the error acordingly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org