[Bug 14744] New: Cannot select guarantor when quote in one of the fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Bug ID: 14744 Summary: Cannot select guarantor when quote in one of the fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a field (here it's the branch name) contains a quote, the Select button doesn't work in guarantor_search.pl. For example, if our branch is "Bibliothèque d'Avignon", the resulting json in the link is all broken and the "select" does nothing. Setup: - Have a Child patron and Adult patron in your DB. - In Admin/Libraries and Group, modify the name to add a ' in the middle. Test: - Modify your child patron. - The second section should be "Guarantor Information" - Click the "Set to patron" button - Enter the info to find your adult - In the resulting list, click the Select at the end of the line - Nothing will happen - Hover over the link, you'll see the gibberish inside. - Remove the ' from the branch name. Do the steps above. Everything is alright. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed. I tested by having a guarantor with a single quote in his/her branch name. The same happens if the single quote appears in the guarantor's name (d'Artangnan) or in the address / city (Bourbon-l'Archambault) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 --- Comment #2 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42416&action=edit CAM 2145 - Bug 14744 - Fix select guarantor when quote in one of the fields The quote was wrapping the onclick attribute of the select, so i have replaced all of the quotes in borrower data (only for this section) by ' (single quote for html) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 --- Comment #3 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42417&action=edit CAM 2145 - Bug 14744 - Fix window closing when selecting a guarantor After slecting a guarantor, the window was not closing. Some parts of the form in the user_select function are not defined yet, so the JavaScript was crashing when it encounters the undefined form fields preventing it from closing the window. I only had if conditions to prevent the script form bugging and to close the window. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Genevieve Plantin <genevieve.plantin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |genevieve.plantin@inlibro.c | |om Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 42419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42419&action=edit Quotes from guarantor fields show up encoded in patrons address fields If I select a gaurantor displayed encoded with quotes in the address fields, the patron's address fields are populated with encoded values. --- BTW: Is it a feature or a bug that the patron main address is changed to the guarantor's main address? (That happens already before applying the patches). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14123 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #5 from Joonas Kylmälä <j.kylmala@gmail.com> --- Not sure if I'm right but I think there has been at least 2 similar bug reports to this but I couldn't find them now... Anyways, there has been already discussion about some general fix for this (and If I remember right there is already some work done). The fix where the work has been done was not that far away from coming to master (maybe couple of months) but there was also another idea to wait ~2 years until template toolkit's newer version comes to different GNU/Linux distros (and it fixes the problem). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14505 --- Comment #6 from Joonas Kylmälä <j.kylmala@gmail.com> --- It was Bug 14505 where there was discussion about this kind of bugs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14691 --- Comment #7 from Marc Véron <veron@veron.ch> --- ...and Bug 14691 - Can't delete patron with ' character in cardnumber -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 Status|Needs Signoff |In Discussion CC| |liz@catalyst.net.nz --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- I'd love to see these bugs fixed, I think we should put our attention into bug 13618 rather than fixing all of these independent occurrences of the same-ish problem. 13618 will need heaps of testing. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org