[Bug 17722] New: t/db_dependent/PatronLists.t doesn' t run inside a transaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Bug ID: 17722 Summary: t/db_dependent/PatronLists.t doesn't run inside a transaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57968&action=edit Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57968|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57986&action=edit [SIGNED-OFF] Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57986|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57997&action=edit Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master fro 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17722 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org