[Bug 30792] New: Item cover images don't load in "Other holdings" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 Bug ID: 30792 Summary: Item cover images don't load in "Other holdings" tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 26145 If you have SeparateHoldings enabled and item-level local cover images on the items which appear under the "Other holdings" tab, these covers will not load. Line 1154 of detail.tt: if( $(coverSlide).find(".cover-image:visible").length < 1 ){ This doesn't consider the possibility of correctly-loaded cover image under a hidden tab. Removing the ":visible" seems to fix it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 [Bug 26145] Add the ability to attach a cover image at item level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- That seems to work for me. I think the :visible was for the OPAC, where we had services that hide the div when no images were there. We should keep in mind that is code is the same one that is used for the biblio images, and so there are much more use cases to test (turning on the different cover services). We could apply the same change at the OPAC, to not have the code diverge between the two interfaces, but then it's even harder to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** This bug has been marked as a duplicate of bug 30234 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org