[Bug 30874] New: Simplify patron category handling in memberentry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Bug ID: 30874 Summary: Simplify patron category handling in memberentry Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 [Bug 12446] Enable an adult to have a guarantor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135524&action=edit Bug 30874: Replace categoryname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135525&action=edit Bug 30874: Reduce number of category fetches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135526&action=edit Bug 30874: 2 more - need more investigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135527&action=edit Bug 30874: Simplify categories loop construction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Fancy a code golf? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135527|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135528&action=edit Bug 30874: Simplify categories loop construction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135529&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Fancy a code golf? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looked at the first patches and it's obviously an improvement. I can't offer a lot of 'golfing', but maybe we could still get some improvements out of these patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Bug 30874 depends on bug 12446, which changed state. Bug 12446 Summary: Enable an adult to have a guarantor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- ping? It would be a shame to lose this enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135524|0 |1 is obsolete| | Attachment #135525|0 |1 is obsolete| | Attachment #135526|0 |1 is obsolete| | Attachment #135528|0 |1 is obsolete| | Attachment #135529|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138443&action=edit Bug 30874: Replace categoryname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138444&action=edit Bug 30874: Reduce number of category fetches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138445&action=edit Bug 30874: 2 more - need more investigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138446&action=edit Bug 30874: Simplify categories loop construction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138447&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Test plan: Create a new patron in a given category => Form show the dropdown with the selected category Edit again => Value is kept Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee Edit the patron, change the category, and confirm that the different limitation are correctly applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138443|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138545&action=edit Bug 30874: Replace categoryname == Test plan == 1. Apply all patches 2. Create a new patron in a given category => Form show the dropdown with the selected category 3. Edit again => Value is kept 4. Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee 5. Edit the patron, change the category, and confirm that the different limitation are correctly applied. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138444|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138546&action=edit Bug 30874: Reduce number of category fetches Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138445|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138547&action=edit Bug 30874: 2 more - need more investigation Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138446|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138548&action=edit Bug 30874: Simplify categories loop construction Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138447|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138549&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) Added test plan to 1st patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138545|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 138637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138637&action=edit Bug 30874: Replace categoryname == Test plan == 1. Apply all patches 2. Create a new patron in a given category => Form show the dropdown with the selected category 3. Edit again => Value is kept 4. Edit a category to give it specific values for: messaging prefs, password strength/length, can be guarantee 5. Edit the patron, change the category, and confirm that the different limitation are correctly applied. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138546|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 138638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138638&action=edit Bug 30874: Reduce number of category fetches Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138547|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 138639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138639&action=edit Bug 30874: 2 more - need more investigation Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138548|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 138640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138640&action=edit Bug 30874: Simplify categories loop construction Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138549|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 138641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138641&action=edit Bug 30874: Remove category_type In which case do we pass category_type to this script? Am I missing something? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 22.05.x dependencies, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org