[Bug 6954] New: z39.50 results highlighting not sticking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Bug #: 6954 Summary: z39.50 results highlighting not sticking Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org When doing a Z search if you click on a row it highlights in yellow. If you click a preview link that yellow highlight goes away making it hard to figure out which line you were viewing. In 3.4 this highlighting used to stick even after you clicked the preview link. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-10-03 16:15:56 UTC --- [12:10] <oleonard> nengard: Do you have an example of that working the way you expect? [12:10] <oleonard> I agree that the way you describe it is how it *should* work. [12:11] <nengard> i have to admit I didn't remember it ever working that way, but a partner of ours said it did and I took his word for it -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-04 15:40:54 UTC --- On line 23 of the cataloguing/z3950_search.tt, in the function closemenu(), the selection highlighting is turned off as part of the closing of the menu. This may relate to the fix for 6367; the persistence of the highlighting could have been an unintentional benefit of the misplaced menu ID grabbing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-04 16:49:44 UTC --- Created attachment 5698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5698 Proposed patch Moves the "addClass" call up to right after the row is defined in the JS, so the highlighting of the row will persist after using the popup menu. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5698|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-10-04 17:06:21 UTC --- Created attachment 5700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5700 [SIGNED-OFF] Bug 6924: z39.50 results highlighting not sticking Moves the highlighting call of the JS up to right after 'row' is defined, so the highlighting will stick even after you click on of the popup menu options http://bugs.koha-community.org/show_bug.cgi?id=6954 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-04 17:30:45 UTC --- Question to the community: should this count as a new feature (and thus wait until after 3.6 is released), or as a bugfix for integration immediately? I do not feel qualified to answer, as this patch was a request by a ByWater partner, and it would be in my own self interest for it to be committed soon. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |ian.walls@bywatersolutions. | |com --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-10-04 18:05:25 UTC --- It's a tiny change to a template. No reason not to include it now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-05 07:14:16 UTC --- I think it's not a new feature but a small improvement to make things easier. +1 for inclusion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-15 12:20:54 UTC --- Given the tiny nature of this patch (moved 1 line), and it's benefit (without introducing new strings), I'm marking this as Passed QA. Integration into 3.6 is of course at the RM's discretion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6954 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-18 03:16:06 UTC --- With the +1 from one of the translators and sign off from QA, I'm happy to push this, please test. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org