https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 58158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58158&action=edit Bug 17766 - Patron notification does not work with multi item holds This patch fixes notification when same biblio has multiple reserves with same borrower, introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method _koha_notify_reserve but sends itemnumber and biblionumber instead of record_id. To test: Prerequisites: - One biblio with two items attached - A patron with hold_filled notification activated - A letter for HOLD with <<reserves.reserve_id>> in it 1) Place two reservations on same biblio 2) checkin item x on pickup branch, observe patron message generated 3) checkin item y on pickup branch, observe patron message generated 4) note that reserve_id is the same on both messages, which is wrong 5) apply this patch and repeat 1-3 6) now observe notifications have correct (different) reserve_id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58536|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58948&action=edit Bug 17766 - Patron notification does not work with multi item holds This patch fixes notification when same biblio has multiple reserves with same borrower, introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method _koha_notify_reserve but sends itemnumber and biblionumber instead of record_id. To test: Prerequisites: - One biblio with two items attached - A patron with hold_filled notification activated - A letter for HOLD with <<reserves.reserve_id>> in it 1) Place two reservations on same biblio 2) checkin item x on pickup branch, observe patron message generated 3) checkin item y on pickup branch, observe patron message generated 4) note that reserve_id is the same on both messages, which is wrong 5) apply this patch and repeat 1-3 6) now observe notifications have correct (different) reserve_id Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.