[Bug 27899] New: Missing description for libraryNotPickupLocation on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Bug ID: 27899 Summary: Missing description for libraryNotPickupLocation on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org As the attached screenshot highlights, there's no description for that error status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 117944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117944&action=edit screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 [Bug 7534] Add an option on library level to indicate if a library can be chosen as pick-up location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118235&action=edit Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - Start the process of placing a hold on the title. - After selecting a patron to place the hold for, look at the table of items under "PLace a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118240&action=edit Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - Start the process of placing a hold on the title. - After selecting a patron to place the hold for, look at the table of items under "PLace a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I am missing something in the test plan: - I am using "Fairview" for testing. - I have set Fairview to be no pickup location in libraries. - I have made sure that there are no other rules blocking a hold on the items. - In the pick-up location pull down, Fairview no longer shows up. Therefore... there is no error for any item specific hold? I am not sure what I am missing here in order to trigger the error. I think there was some recent work on pick-up locations - maybe something changed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119186&action=edit Screenshot showing more context You're on the right track but you're looking at the wrong area of the page. See the attached screenshot, in the section with the heading "Place a hold on a specific item." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, sorry, I did check there, but it was not showing. I only got the general message "No items can be blaced on hold" IIRC. Maybe something different in configuration? Not unhappy if someone else wants to try their hand at this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same as Katrin for me, or there is something missing in the test plan or it's related to bug 28118. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28284 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118240|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120864&action=edit Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - Start the process of placing a hold on the title. - After selecting a patron to place the hold for, look at the table of items under "Place a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Rebased for additional testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Switch back to NQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120864|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121342&action=edit Bug 27899: Missing description for libraryNotPickupLocation on request.pl This patch adds text to the holds template in the staff client so that if a particular item is at a library which isn't a hold location the error message is descriptive. To test, apply the patch and go to Administration -> Libraries. - Change one of your libraries so that "Pickup location" is set to "No." - Locate a title in the catalog which has an item at that location. - The "pick up at" list will exclude the library so and additional steps must be taken to get the message - Select a patron and set their library to the one we can't pick up at. - Start the process of placing a hold on the title. - After selecting the patron to place the hold for, look at the table of items under "Place a hold on a specific item." - The item located at the library you modified should show an error message in the "Hold" column, "Library is not a pickup location." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, code looks good, change makes sense, QA script happy Passed QA :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Also added a step in the test plan to be sure to get the message: - The "pick up at" list will exclude the library so and additional steps must be taken to get the message - Select a patron and set their library to the one we can't pick up at. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org