[Bug 13591] New: Rss sample templates have hardcoded urls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Bug ID: 13591 Summary: Rss sample templates have hardcoded urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The sample templates in misc/cronjobs/rss have hardcoded urls the should be using suspref OPACBaseURL The contents of rss are rather neglected but many sites seem to want to use this, while most may want some customizations the samples should work out of the box in a sensible fashion at present if you create a list of new acquisitions The links are hardcoded to nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 36762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36762&action=edit Proposed patch Simple to test Generating an xml file without the patch (e.g. ./rss.pl ./lastAcquired-1.0.conf ) creates an xhtml page with all the links going to library.org.nz Doing the same with the patch applied and all links should be to the site's own opac as specified in OPACBaseURL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 --- Comment #2 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 38902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38902&action=edit Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren@yahoo.no Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Corrected Eivin's sign off, by obsoleting unsigned version, and marking unsigned. Enjoy QA'ing. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38902|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38972&action=edit [PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Good catch Colin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org