[Bug 31887] New: Search on MARC field does not work in Elasticsearch mappings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Bug ID: 31887 Summary: Search on MARC field does not work in Elasticsearch mappings table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I think we must define attribute data-search in each cell : https://datatables.net/examples/advanced_init/html5-data-attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 142229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142229&action=edit Bug 31887: Fix search on MARC field in Elasticsearch mappings table In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Go to tab 'Bibliographic records' 3) Enter in search field a used MARC field (like 245) => Table gets filtered by rows with mapping on searched field 4) Enter in search field the field+subfield used for issues (952l in KTD) => Table gets filtered by rows with mapping on field+subfield -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142229|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142230&action=edit Bug 31887: Fix search on MARC field in Elasticsearch mappings table In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Go to tab 'Bibliographic records' 3) Enter in search field a used MARC field (like 245) => Table gets filtered by rows with mapping on searched field 4) Enter in search field the field+subfield used for issues (952l in KTD) => Table gets filtered by rows with mapping on field+subfield Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142230|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143032&action=edit Bug 31887: Fix search on MARC field in Elasticsearch mappings table In Elasticsearch mappings table, in tabs with MARC fields, searching using DataTable search field does not work for MARC fields / subfields. This is because cell contains an input HTML tag with MARC data in attribute value. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Go to tab 'Bibliographic records' 3) Enter in search field a used MARC field (like 245) => Table gets filtered by rows with mapping on searched field 4) Enter in search field the field+subfield used for issues (952l in KTD) => Table gets filtered by rows with mapping on field+subfield Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Great little fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm a fan of JS DataTable ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32519 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org