[Bug 6214] New: Staff client search results template error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6214 Bug #: 6214 Summary: Staff client search results template error Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Blocks: 5917 In the Template::Toolkit transition several commas have been translated to "comma." "<!-- TMPL_IF NAME="ms_any,phr" -->" has become "[% IF (ms_anycommaphr) %]" I'm assuming a template variable name with a comma is invalid under TT. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6214 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-20 22:25:47 UTC --- Yes , is not part of a valid variable name in perl The code should have been changed accordingly I will check -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6214 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-20 22:30:07 UTC --- if ($indexes[0] && (!$indexes[1] || $params->{'scan'})) { my $idx = "ms_".$indexes[0]; $idx =~ s/\,/comma/g; # template toolkit doesnt like variables with a , in it $template->param($idx => 1); } Yep looks ok to me, is the results page actually erroring owen, cos im thinking of marking this works for me -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6214 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-04-20 23:47:53 UTC --- I found the problem by searching for instances of "comma" based on other template errors. Judging from the template, it's part of the "Scan indexes" functionality, something I don't use or understand. There's no error in standard operation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6214 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-21 20:13:25 UTC --- Yeah its fixed in the perl, its setting the variables to match what is in the template, so i think tis all good -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org