[Bug 16865] New: marking branchcode unwanted breaks self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Bug ID: 16865 Summary: marking branchcode unwanted breaks self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you add branchcode to PatronSelfRegistrationBorrowerUnwantedField then self registration fails silently. The library and the user have no idea what happened. We should have an error and/or not let branchcode be added to that preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- -- or add a default branch code? :) Similar to bug 16892 that I did for the OAuth2 auto-register. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17364 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is not critical, it's a configuration issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is that when hiding the branchcode, which is desirable for singel branch libraries, the email disappears. And without the email the verification process breaks. Normal is ok, becuase you can have work around it, but would be nice to see fixed. I see no reason why there should be any link between hiding email and branch. Also: altcontactnote can't be hidden... haven't investigated deeper yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|marking branchcode unwanted |Patron self registration: |breaks self registration |hiding lbranchcode also | |hides email -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron self registration: |Patron self registration: |hiding lbranchcode also |hiding branchcode hides |hides email |email and breaks workflow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, I do not understand. Which email are you talking about? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The primary email field in the form where you enter the patron data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for all the typos in my previous comment. The system preference *unwanted* takes the database column names from the borrowers table. When you enter 'branchcode' it will hide more fields, especially the primary email (email) field, which doesn't make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate, I have added "branchcode" to PatronSelfRegistrationBorrowerUnwantedField, when I go to opac-memberentry.pl I do not see the library entry and see "primary email" in the "contact information" part. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's odd, I was testing in a 16.11.12. Will try to retest on master soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron self registration: |Patron self registration: |hiding branchcode hides |hiding branchcode gives |email and breaks workflow |error Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Patrons |OPAC --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I retested this on master and couldn't replicate the 'disappearing email', but found another explosion: Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 PatronSelfRegistrationBorrowerUnwantedField: branchcode PatronSelfRegistrationLibraryList: CPL (same with empty) Maybe we should catch the error and at the same time add a note to the pref that branchcode should not be hidden? Not sure how we determine the branch for the patron if it is hidden. Maybe we could hide it, if there is only one entry (no more libraries configured, *LibraryList only has one entry) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 26568 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- *** This bug has been marked as a duplicate of bug 17364 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org