[Bug 28382] New: 'Reserve' should be passed through as transfer reason appropriately in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Bug ID: 28382 Summary: 'Reserve' should be passed through as transfer reason appropriately in branchtransfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The 'branchtransfers' script can be used to initiate a transfer, but it is currently hard coded to always record the transfer trigger as 'Manual'.. in some cases the transfer prompts the user that a reserve has been found and allows them to make the decision that the transfer if to satisfy the reserve.. as such we should pass through the trigger in this case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27064 Blocks| |25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121145&action=edit Bug 28382: Set trigger to 'Reserve' when actioning a resver transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121145|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 121152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121152&action=edit Bug 28382: Set trigger to 'Reserve' when actioning a resver transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can/Should we turn "Reserve" into "hold" to follow terminology guidelines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's pre-existing, and it's a code that translates in templates to a suitable string.. I'm not too worried either way really.. it might be nice, but at the same time I think it should be done on it's own bug..? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #4)
It's pre-existing, and it's a code that translates in templates to a suitable string.. I'm not too worried either way really.. it might be nice, but at the same time I think it should be done on it's own bug..?
I was nore sure if it was introduced here or reused - if it's preexisting I completely agree that it's out of scope here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121152|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 121724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121724&action=edit Bug 28382: Set trigger to 'Reserve' when actioning a reserve transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. Signed-off-by: David Nind <david@davidnind.com> JK: fix typo resver -> reserve Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |joonas.kylmala@helsinki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@helsinki.fi |y.org | --- Comment #7 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- PQA and switching status to bug because the reason was not right previously. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Bug 28382 depends on bug 27064, which changed state. Bug 27064 Summary: Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27064 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org