[Bug 14821] New: Don't show item in checked in list, when it wasn't checked in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Bug ID: 14821 Summary: Don't show item in checked in list, when it wasn't checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This is what currently happens: - Unset AnonymousPatron - Set a patrons history to "never" - Check in an item from this patron's account - It should show an error message, but the item will still be listed in the list of checked-in items We should only show an error message or at least a helpful note that the item has not really been returned in the table below. There might be other cases where this happens - so could be a more general fix is needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14655 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42548&action=edit Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14655 | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |14655 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 [Bug 14655] Cannot checkin without Anonymous Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42548|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44054&action=edit Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm that the checkin table hasn't to be populated with info on items which haven't been checked in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44054|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44247&action=edit [PASSED QA] Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm that the checkin table hasn't to be populated with info on items which haven't been checked in. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org