[Bug 12066] New: renewals not tracking branch in stats
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Bug ID: 12066 Summary: renewals not tracking branch in stats Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The OpacRenewalBranch is set to renew at the library the item was checked out, but it seem that all renewals are being recorded as NULL. mysql> select count(*) from statistics where branch is null; +----------+ | count(*) | +----------+ | 457 | +----------+ 1 row in set (0.00 sec) mysql> select count(*) from statistics where type='renew' and branch is null; +----------+ | count(*) | +----------+ | 457 | +----------+ 1 row in set (0.03 sec) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Summary|renewals not tracking |New renew page in staff |branch in stats |client doesn't record | |branch in statistics Severity|normal |major --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- As far as I can tell this bug only affects renewals which are done through the new renew script (circ/renew.pl). I tried doing renewals through the OPAC (both by clicking on the link and by checking boxes and submitting the form) and in the staff client (by scanning a barcode in the checkout form and by checking boxes in the table of checked out items). Only when I use circ/renew.pl does the branch end up NULL. I notice that opac-renew.pl contains all the logic for determining which branch should be passed to AddRenewal(). I would think that logic should be separated out so that it doesn't have to be duplicated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> ---
I notice that opac-renew.pl contains all the logic for determining which branch should be passed to AddRenewal().
Which, now that I actually think it through, is unnecessary for circ/renew.pl because we have the logged-in branch to pass to AddRenewal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39351&action=edit Bug 12066 - New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39351|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39703&action=edit [SIGNED-OFF] Bug 12066: New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested pre and post patch, now branch is saved No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39703|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39722&action=edit [PASSED QA] Bug 12066: New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested pre and post patch, now branch is saved No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Patch pushed to 3.18.x will be in 3.18.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org