https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53647&action=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53647|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 53856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53856&action=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. https://bugs.koha-community.org/show_bug.cgi?id=16692 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53856|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53884&action=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky@gmail.com Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Gracie <grace.mcky@gmail.com> --- While testing this bug I came across the fact that in the 'Add Item' form there are no repeatable fields, what "clone" button are you referring to? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |grace.mcky@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67814&action=edit Screenshot of formatting issue on serial collection page There is a tiny issue with the table heading on the serials collection page, when a subscription is renewed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100923&action=edit Bug 16962: Remove the use of "onclick" from serial collection template This patch removes the use of event attributes like "onclick" from the serial collection template. Events are now defined in JavaScript. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly and affect only that tab. - On a subscription which has expired, test that the "Renew" button works correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103328|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 103381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103381&action=edit Bug 16962: Remove the use of "onclick" from serial collection template This patch removes the use of event attributes like "onclick" from the serial collection template. Events are now defined in JavaScript. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly and affect only that tab. - On a subscription which has expired, test that the "Renew" button works correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch removes the use release notes| |of event attributes like | |"onclick" from the serial | |collection template. Events | |are now defined in | |JavaScript. This is a | |behind the scenes | |improvement - everything | |should continue to work as | |it did before. -- You are receiving this mail because: You are watching all bug changes.