[Bug 34973] New: JS warning in the console: "Glyph bbox was incorrect"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Bug ID: 34973 Summary: JS warning in the console: "Glyph bbox was incorrect" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com downloadable font: Glyph bbox was incorrect (glyph ids 1 2 3 4 5 8 9 10 11 12 13 14 16 17 19 22 24 28 32 34 35 38 39 40 43 44 45 46 47 50 51 52 53 55 56 58 60 61 62 64 67 68 70 71 72 73 74 78 79 80 81 83 90 96 101 103 104 105 108 109 115 116 117 118 120 123 125 135 138 139 140 142 143 144 145 146 148 149 154 155 157 161 162 163 164 165 169 170 171 173 179 181 193 195 203 207 208 210 211 214 218 219 223 225 227 228 229 230 235 236 237 238 239 240 245 246 247 248 249 250 251 252 253 254 255 256 257 263 264 266 268 271 275 278 279 280 281 282 283 284 285 286 287 288 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 321 335 338 339 340 342 344 345 346 353 354 356 357 358 359 362 363 365 366 371 373 374 379 381 382 383 386 389 390 391 393 394 406 407 412 413 418 419 420 424 432 433 439 448 449 450 451 454 455 456 457 472 479 480 481 482 485 486 490 491 493 499 500 501 503 508 509 513 515 516 525 527 528 532 535 541 542 543 549 550 551 552 554 555 556 558 560 569 571 602 603 604 607 608 609 614 615 617 618 623 626 627 643 644 645 647 650 651 654 655 656 657 662 663 664 665 670 671 672 674 675 679 680 681 682 683 698 699 708 712 714 717 718 729 730 732 735 736 739 746 747 752 761 762 767 774 776 777 778 779 788 789 790 794 796 798 800 801 803 804 806 826 828 829 831 835 836 838 839 840 841 842 843 844 845 848 849 856 857 861 862 863 871 873 874 880 882 892 895 900 908 911 913 925 928 929 930 933 936 937 938 941 942 943 944 945 948 949 950 952 958 960 961 962 964 966 967 969 973 974 978 979 980 981 982 989 998 1000 1001 1005 1006 1008 1009 1011 1012 1013 1016 1020 1026 1027 1031 1036 1037 1042 1045 1048 1050 1052 1053 1057 1058 1060 1063 1072 1073 1076 1084 1087 1099 1104 1110 1111 1112 1116 1117 1121 1122 1124 1131 1136 1140 1141 1142 1147 1148 1151 1157 1163 1167 1168 1170 1177 1186 1187 1193 1196 1199 1200 1201 1204 1205 1208 1211 1212 1217 1218 1220 1224 1226 1228 1229 1230 1231 1232 1233 1235 1236 1237 1238 1243 1246 1247 1249 1251 1256 1258 1259 1260 1261 1265 1268 1269 1271 1272 1273 1275 1276 1279 1285 1289 1290 1291 1292 1296 1297 1303 1304 1305 1309 1310 1311 1312 1317 1319 1320 1324 1325 1328 1329 1330 1331 1334 1335 1337 1339 1341 1343 1356 1357 1363 1369 1371 1372 1375 1376 1377 1380 1381 1382 1384 1387) (font-family: "Font Awesome 6 Free" style:normal weight:900 stretch:100 src index:0) source: http://kohadev-intra.mydnsname.org:8081/intranet-tmpl/lib/fontawesome/webfon... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- See https://github.com/FortAwesome/Font-Awesome/issues/19925 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Observed this when testing another bug: Staff interface > Authorites > [any type]. Simpler way to reproduce: hard refresh the staff interface home page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #3 from David Nind <david@davidnind.com> --- The bug report for Font Awesome indicates that it was fixed in 6.5.0(?): https://github.com/FortAwesome/Font-Awesome/issues/19925#issuecomment-188251... An update to Font Awesome version is required to fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|JS warning in the console: |Update Font Awesome to fix |"Glyph bbox was incorrect" |JS warning in the console | |for Firefox: "Glyph bbox | |was incorrect" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38014 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|ASSIGNED |Needs Signoff Sponsorship status|--- |Sponsored Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198628&action=edit Bug 34973: Upgrade Font Awesome in the OPAC to 7.2 We are using Font Awesome 6.3 in the OPAC. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch adds Font Awesome to the list of packages in node_modules and moves the Font Awesome SCSS into _common.scss so that it can be bundled along with Bootstrap and other 3rd party assets. Despite the fact that _common.scss grabs FA SCSS files directly from node_modules I've added the FA font files to css/fonts. I was unable to see how to reference the webfonts directory in node_modules/@fortawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the OPAC SCSS. - Clear your browser cache. - Test many pages in the OPAC to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: Star ratings on the user summary page, <legend>s on the search history page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I think the QA tool warnings about "new_line_at_the_end_of_file" can be ignored because the files are .woff2 font files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 198685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198685&action=edit Bug 34973: Upgrade Font Awesome in the OPAC to 7.2 We are using Font Awesome 6.3 in the OPAC. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch adds Font Awesome to the list of packages in node_modules and moves the Font Awesome SCSS into _common.scss so that it can be bundled along with Bootstrap and other 3rd party assets. Despite the fact that _common.scss grabs FA SCSS files directly from node_modules I've added the FA font files to css/fonts. I was unable to see how to reference the webfonts directory in node_modules/@fortawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the OPAC SCSS. - Clear your browser cache. - Test many pages in the OPAC to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: Star ratings on the user summary page, <legend>s on the search history page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Used Firefox to test. 2. Apply the patch 3. Update things: yarn install 4. Update the CSS: yarn build 5. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #5)
I think the QA tool warnings about "new_line_at_the_end_of_file" can be ignored because the files are .woff2 font files.
Adjusted the test on https://gitlab.com/koha-community/qa-test-tools/-/work_items/114 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- I get an error: $ gulp css && gulp css --view opac [09:15:15] Using gulpfile /kohadevbox/koha/gulpfile.js [09:15:15] Starting 'css'... [09:15:15] Finished 'css' after 13 ms [09:15:26] Using gulpfile /kohadevbox/koha/gulpfile.js [09:15:26] Starting 'css'... [09:15:26] Finished 'css' after 13 ms Error in plugin "sass" Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: This variable was not declared with !default in the @used module. ╷ 3 │ $font-path: "./fonts" │ ^^^^^^^^^^^^^^^^^^^^^ ╵ koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss 3:5 @import koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss 1:9 root stylesheet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Shouldn't those 2 be adjusted as well? koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt: font-family: "Font Awesome 6 Free"; koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt: font-family: "Font Awesome 6 Free"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #9)
I get an error:
$ gulp css && gulp css --view opac [09:15:15] Using gulpfile /kohadevbox/koha/gulpfile.js [09:15:15] Starting 'css'... [09:15:15] Finished 'css' after 13 ms [09:15:26] Using gulpfile /kohadevbox/koha/gulpfile.js [09:15:26] Starting 'css'... [09:15:26] Finished 'css' after 13 ms Error in plugin "sass" Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: This variable was not declared with !default in the @used module. ╷ 3 │ $font-path: "./fonts" │ ^^^^^^^^^^^^^^^^^^^^^ ╵ koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss 3:5 @import koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss 1:9 root stylesheet
Forget that, I forget to run `yarn install` first! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198704&action=edit Bug 34973: Upgrade Font Awesome in the OPAC to 7.2 We are using Font Awesome 6.3 in the OPAC. The current version is 7.2. Upgrading will eliminate the repeated warnings in the browser console about "Glyph bbox was incorrect." The patch adds Font Awesome to the list of packages in node_modules and moves the Font Awesome SCSS into _common.scss so that it can be bundled along with Bootstrap and other 3rd party assets. Despite the fact that _common.scss grabs FA SCSS files directly from node_modules I've added the FA font files to css/fonts. I was unable to see how to reference the webfonts directory in node_modules/@fortawesome. The many changed .inc and .tt files are a result of a missed aspect of our upgrade to Bootstrap 5. The "sr-only" class was removed in BS5 but the Font Awesome CSS included its own "sr-only" class. This made up for the fact that we missed the required upgrade to BS5's "visually-hidden." As soon as Font Awesome's "sr-only" was gone all these mistakes were made visible. To test, apply the patch and run 'yarn install.' - Rebuild the OPAC SCSS. - Clear your browser cache. - Test many pages in the OPAC to confirm that no icons are missing. - Check changes to the templates to confirm that "sr-only" has been replaced with "visually-hidden." - Places where a broken "sr-only" class would be obvious: Star ratings on the user summary page, <legend>s on the search history page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198705&action=edit Bug 34973: Adjust opac-curbside-pickups.tt Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198826&action=edit Bug 34973: (follow-up) Use lib/fontawesome for font location It makes more sense to use lib/fontawesome/webfonts as the source directory for Font Awesome font files rather than bootstrap/css/fonts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198827&action=edit Bug 34973: (follow-up) Remove old Font Awesome asset references from SCO and SCI The self-checkout and self-checkin templates no longer need explicit inclusion of Font Awesome CSS because it's rolled into _common.scss and thus sco.scss. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42564 [Bug 42564] Upgrade Font Awesome in the staff interface to 7.2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #16 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- 1) Access http://localhost:8080/ 2) Notice the search button has an icon 3) Apply patches 4) Run yarn install 5) Notice the search button has no icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Did you run 'yarn build' after 'yarn install' ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #18 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Owen Leonard from comment #17)
Did you run 'yarn build' after 'yarn install' ?
Had not. Thank you Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 --- Comment #19 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes browser console release notes| |JavaScript errors about | |Font Awesome fonts for the | |OPAC when using Firefox. | |The version of Font Awesome | |used was upgraded from 6.3 | |to 7.2 as part of fixing | |this. Summary|Update Font Awesome to fix |Update Font Awesome for the |JS warning in the console |OPAC to fix JavaScript |for Firefox: "Glyph bbox |warning in the console for |was incorrect" |Firefox: "Glyph bbox was | |incorrect" --- Comment #20 from David Nind <david@davidnind.com> --- Note that this only fixes the OPAC. Bug 42564 (signed off) fixes the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | CC| |lucas@bywatersolutions.com --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to 26.05.x for 26.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I won't backport this to 25.11.x unless someone asks for -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #23 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org