[Bug 30705] New: Age hint on patron form is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 Bug ID: 30705 Summary: Age hint on patron form is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To test: - Edit a patron record - Set date of birth to today - Note that the age hint claims the user is -1 year 11 months :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some more clues: - the age hint only appears on editing, not when adding a patron and overwrites the format hint when clicking outside the input field - dates in the past month calculate the age correctly - dates in the current month, future and past, show the issue - Example: 05/01/2022 (MM/DD/YYYY) Age: -1 year 11 months -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The write_age function seems to be a little buggy... If you pick a date which is less than one month ago it won't send an age string, so the date format hint is not replaced. If you pick a date more than one month ago and *then* pick a date less than one month ago (or you clear the field) the first age will remain. The original patch adding the patron's age omitted handling of days, but it would be nice if it calculated the age in days *if* the date of birth is under one month ago. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, you don't get the negative -1 and 11 months? Because that just seems plain wrong when the person is just a day old... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- No I don't get the negatives. I'm testing with Bug 30514, Bug 30706, and Bug 30713 applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't recreate the -1, however there is a bug: - Select a date one year ago => Age 1 year OK - Select today => Age 1 year KO The date is not updated if a date in the last month is selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Summary|Age hint on patron form is |Updating the date of birth |wrong |sometimes shows wrong age --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's behaving a little different now: 1) Edit any existing patron, like Henry Acevedo 2) Notice he is 64 years old 3) Update the date to any past date in the current month -> the age hint doesn't update: 64 years 4) Change the date to a year back -> the age hint will now be updated: 1 year It looks like it doesn't do the negative any more, but that it should always update the displayed date, even if it's 0 years? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Owen Leonard from comment #4)
No I don't get the negatives. I'm testing with Bug 30514, Bug 30706, and Bug 30713 applied.
I don't see this bug in the current master. It looks like it was resolved by these patches in 22.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for testing Brendan, happy to close this :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org