[Bug 39400] New: "Jump to add item form" doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Bug ID: 39400 Summary: "Jump to add item form" doesn't work Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org The new link to jump to the form from the top of a long item list is not working and results in a JS error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Are your steps to reproduce: 1. Edit an existing item, and then...? The link targets the "<h2 id="additema">Add item</h2>" which only exists when you are not editing an existing item. The patch adding it expected that edit links would instead target #edititem, and added that target to links from the holdings table, but not from the Items tab (and I wouldn't be surprised if there are other edit item links, say in serials or acq). But even if your edit link targets #edititem, you still might scroll up and then you'll have a broken link pretending it will take you back to the form, which should have the same conditional that determines whether to have an additema or an edititem, [% IF op != 'cud-saveitem' %]#additema[% ELSE %]#edititem[% END %]. Or, we could just target #f since the form is always there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Not acq (which targets #edititem) or serials (which just has a Manage items link labelled Edit items), but along with the Items tab, item search, reports which show itemnumber, and batch modify items all have links to edit a particular item without a hash to scroll to the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The link with the text shows right on top of the item table to the left when you edit any item in the catalog. I am pretty sure it's just JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36320 Summary|"Jump to add item form" |"Jump to add item form" |doesn't work |doesn't work while editing | |an existing item Assignee|oleonard@myacpl.org |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Ah, indeed it is JS because of bug 36320 comment 10, which would have left me very confused when I changed the link href to "f" and still scrolled to "additema" (or not, when there is no additema). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 [Bug 36320] Clicking 'Edit items' from detail page in staff interface leads to 'Add item' screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179588&action=edit Bug 39400: "Jump to add item form" doesn't work while editing an existing item The link at the top of the item editor page to "Jump to add item form" tries to scrollIntoView the element with id="additema", but that element only exists while you are adding a new item. While you are editing an existing item, it is replaced by an element with id="edititem". Whichever element you have at the moment is always just below the form with id="f", so we can just scroll that into view instead. Test plan: 1. Without the patch, go to the details page for any bib record with at least one item, and click the Edit button on the row for an item in the holdings table. 2. You should be scrolled down to the form for editing that item 3. Scroll up to the top of the page, click the Jump to add item form link 4. You will not be scrolled back down to the form 5. Apply patch, shift+reload page 6. Now the link should scroll you back down to the form 7. Return to the biblio details page, click Edit - Manage items and verify that the Jump to add item form link still works when you are not editing an existing item 8. Click the Add multiple copies of this item button and add 30 items 9. Make sure that the link still scrolls the form into view both while you are editing an existing item, and while you are adding a new item Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179588|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179624&action=edit Bug 39400: "Jump to add item form" doesn't work while editing an existing item The link at the top of the item editor page to "Jump to add item form" tries to scrollIntoView the element with id="additema", but that element only exists while you are adding a new item. While you are editing an existing item, it is replaced by an element with id="edititem". Whichever element you have at the moment is always just below the form with id="f", so we can just scroll that into view instead. Test plan: 1. Without the patch, go to the details page for any bib record with at least one item, and click the Edit button on the row for an item in the holdings table. 2. You should be scrolled down to the form for editing that item 3. Scroll up to the top of the page, click the Jump to add item form link 4. You will not be scrolled back down to the form 5. Apply patch, shift+reload page 6. Now the link should scroll you back down to the form 7. Return to the biblio details page, click Edit - Manage items and verify that the Jump to add item form link still works when you are not editing an existing item 8. Click the Add multiple copies of this item button and add 30 items 9. Make sure that the link still scrolls the form into view both while you are editing an existing item, and while you are adding a new item Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- This is a nice fix, but I have one nitpick on wording: the link text still says "Jump to add item form", even when it is actually the edit form. Is there a more general phrase we could put there? Maybe "Jump to item fields form"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- How about "Item entry form" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- "Item entry" still sounds like adding a new item to me...I personally wouldn't call it "entry" if I was editing an existing item. I suppose we could just say "Jump to item form"? Sorry for being so picky on this! I've just seen enough confusion about whether the page was in "add item" state or "edit item" state, and I don't want the link to add to the confusion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- Just last night I was hoping someone would suggest "Jump to item form" so I could then top them with "Jump to form". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Phil Ringnalda from comment #10)
Just last night I was hoping someone would suggest "Jump to item form" so I could then top them with "Jump to form".
Works for me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179624|0 |1 is obsolete| | --- Comment #12 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 180052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180052&action=edit Bug 39400: "Jump to add item form" doesn't work while editing an existing item The link at the top of the item editor page to "Jump to add item form" tries to scrollIntoView the element with id="additema", but that element only exists while you are adding a new item. While you are editing an existing item, it is replaced by an element with id="edititem". Whichever element you have at the moment is always just below the form with id="f", so we can just scroll that into view instead. Test plan: 1. Without the patch, go to the details page for any bib record with at least one item, and click the Edit button on the row for an item in the holdings table. 2. You should be scrolled down to the form for editing that item 3. Scroll up to the top of the page, click the Jump to add item form link 4. You will not be scrolled back down to the form 5. Apply patch, shift+reload page 6. Now the link should scroll you back down to the form 7. Return to the biblio details page, click Edit - Manage items and verify that the Jump to add item form link still works when you are not editing an existing item 8. Click the Add multiple copies of this item button and add 30 items 9. Make sure that the link still scrolls the form into view both while you are editing an existing item, and while you are adding a new item Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 180053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180053&action=edit Bug 39400: (QA follow-up) Adjust link text Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is also a bug in 24.11, requesting backport please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Bug 39400 depends on bug 36320, which changed state. Bug 36320 Summary: Clicking 'Edit items' from detail page in staff interface leads to 'Add item' screen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org