[Bug 7084] New: New Tag on results display missing results_summary class, causing display inconsistency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Bug #: 7084 Summary: New Tag on results display missing results_summary class, causing display inconsistency Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: wizzyrea@gmail.com ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org New Tag on results display missing results_summary class, causing display inconsistency See screenshot: http://screencast.com/t/hnt15kpS7SH9 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2011-10-24 18:35:52 UTC --- Created attachment 6042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6042 Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent with results that have tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |wizzyrea@gmail.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-10-24 18:52:21 UTC --- oops, I made a mistake... proper patch incoming. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6042|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2011-10-24 18:57:14 UTC --- Created attachment 6043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6043 Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent with results that have tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6043|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-10-24 19:02:04 UTC --- Comment on attachment 6043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6043 Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency sheesh. Not my day. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2011-10-24 20:36:02 UTC --- Created attachment 6046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6046 Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent in size with results that have existing tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6046|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@enger.priv.no> 2011-10-25 18:31:06 UTC --- Created attachment 6057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6057 Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to To test: Verify that New Tag text is the same size as all of the other surrounding text. Verify that it is consistent in size with results that have existing tags. See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9 Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that. Signed-off-by: Magnus Enger <magnus@enger.priv.no> I made sure I had a results list with on record with tags and one without. Before applying the patch the "New tag" text and "Add" button were inconsistent for the two records, after applying it they look the same. Nice! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off --- Comment #7 from Magnus Enger <magnus@enger.priv.no> 2011-10-25 18:32:19 UTC --- Sorry, forgot to change the subject line of the signed off patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-10-25 21:02:31 UTC --- lol thanks for signing off on this Magnus. Seriously, what a Monday. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch Status|Signed Off |Passed QA QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 13:59:59 UTC --- QA: Very small template change. Marking it as Passed QA. Applies with one whitespace warning. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-17 16:28:52 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7084 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org