[Bug 40154] New: Deleting an item does not warn about an item level hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Bug ID: 40154 Summary: Deleting an item does not warn about an item level hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: anni.maki-mantila@turku.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl At the moment, Koha doesn't give any warning if user is deleting an item that has a hold attached to it. Item is simply deleted and the item level hold vanishes as well. To reproduce: 1. Make an item level hold 2. Delete the item using alternative A or B: A: Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B: Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared 4. Run following sql report: SELECT * FROM old_reserves WHERE biblionumber = [biblionumber you used in the test] 5. Notice that the item level hold is not found in old_reserves-table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 185216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185216&action=edit Bug 40154: prevent deletion of items with holds This patch prevents deletion of items that have item level holds on them. Test plan: 1. Create an item level hold. 2. Delete the item using alternative A or B: A. Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B. Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared. 4. Apply this patch. 5. Repeat steps 1-3. 6. Notice that the item cannot be deleted and a warning is shown. 7. prove t/db_dependent/Koha/Item.t 8. Run the REST API tests: prove t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185216|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185406&action=edit Bug 40154: prevent deletion of items with holds This patch prevents deletion of items that have item level holds on them. Test plan: 1. Create an item level hold. 2. Delete the item using alternative A or B: A. Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B. Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared. 4. Apply this patch. 5. Repeat steps 1-3. 6. Notice that the item cannot be deleted and a warning is shown. 7. prove t/db_dependent/Koha/Item.t 8. Run the REST API tests: prove t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185407&action=edit Bug 40154: (follow-up) Minor tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 ahennig@hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahennig@hotchkiss.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Signed Off |Passed QA Comma delimited| |Koha-Suomi Oy list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191066&action=edit Bug 40154: prevent deletion of items with holds This patch prevents deletion of items that have item level holds on them. Test plan: 1. Create an item level hold. 2. Delete the item using alternative A or B: A. Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B. Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared. 4. Apply this patch. 5. Repeat steps 1-3. 6. Notice that the item cannot be deleted and a warning is shown. 7. prove t/db_dependent/Koha/Item.t 8. Run the REST API tests: prove t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191067&action=edit Bug 40154: (follow-up) Minor tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please squash tidy commits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191066|0 |1 is obsolete| | Attachment #191067|0 |1 is obsolete| | --- Comment #7 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 191399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191399&action=edit Bug 40154: prevent deletion of items with holds This patch prevents deletion of items that have item level holds on them. Test plan: 1. Create an item level hold. 2. Delete the item using alternative A or B: A. Open the biblios Detail-view -> From the toolbar, open "Edit"-dropdown menu -> Manage items -> Delete the item that has an item level hold attached to it from "Actions"-dropdown menu B. Open the biblios Detail-view -> Select the item that has an item level hold attached to it -> Click "Delete selected items" -> Confirm deletion 3. Notice that the item is deleted without any warning and the item level hold has disappeared. 4. Apply this patch. 5. Repeat steps 1-3. 6. Notice that the item cannot be deleted and a warning is shown. 7. prove t/db_dependent/Koha/Item.t 8. Run the REST API tests: prove t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- The follow-up has been squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- It is a bit unclear what the status should be after squashing the follow-ups. I will change it now to Passed QA as it was before squashing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 --- Comment #11 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40154 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This appears to be a new feature/enhancement rather than a bugfix, so it is not a suitable candidate for backporting to 25.05.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org