[Bug 7718] New: itemnumber not populated in the serial table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Priority: P5 - low Change sponsored?: --- Bug ID: 7718 Assignee: colin.campbell@ptfs-europe.com Summary: itemnumber not populated in the serial table QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Serials Product: Koha If you add items when receiving serials the itemnumber is not put in the serial table even though there is a field for it. This field should be populated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9118&action=edit Bug 7718 - itemnumber not populated in the serial table Modify subroutine C4::Serials::AddItem2Serial to not only add a line to serialitems, but also to update the itemnumber in the serial itself. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com Assignee|colin.campbell@ptfs-europe. |kyle.m.hall@gmail.com |com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Assuming this patch is pushed to master, is there any reason we should not phase out the serialitems table? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #2)
Assuming this patch is pushed to master, is there any reason we should not phase out the serialitems table?
Yes, serials:items is a 1:many relationship. It seems to me that the correct solution here is not to populate serial.itemnumber, but rather to remove it so that no one thinks that they should be using it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree, removing the column instead of filling it is a better solution -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Summary|itemnumber not populated in |Remove itemnumber column |the serial table |from serials table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9118|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15031&action=edit Bug 7718 - Remove itemnumber column from serials table Remove the column 'itemnumber' from the table 'serial'. This is a 1 to many relationship, and this reference does not make sense. The 'serialitems' table handles the relationship between the 'items' table and the 'serial' table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- This patch recycles the database upgrade description from another update ("Add IDreamBooks enhanced content") and lacks a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15031|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15071&action=edit Bug 7718 - Remove itemnumber column from serials table Remove the column 'itemnumber' from the table 'serial'. This is a 1 to many relationship, and this reference does not make sense. The 'serialitems' table handles the relationship between the 'items' table and the 'serial' table. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify serial.itemnumber has been removed from the database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The test plan needs to provide enough information for the tester to confirm that the removal of the column does not break anything. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15071|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15073&action=edit [SIGNED-OFF] Bug 7718 - Remove itemnumber column from serials table Remove the column 'itemnumber' from the table 'serial'. This is a 1 to many relationship, and this reference does not make sense. The 'serialitems' table handles the relationship between the 'items' table and the 'serial' table. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify serial.itemnumber has been removed from the database Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Column removed. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #8)
The test plan needs to provide enough information for the tester to confirm that the removal of the column does not break anything.
I did a check. Can't found any SELECT, DELETE or INSERT that references itemnumber column from serial table. But I may be wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch removes a useless (since the table serialitems exist) column. I agree with Bernardo, I did not find any occurrence of this column. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15073|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18304&action=edit Bug 7718 - Remove itemnumber column from serials table Remove the column 'itemnumber' from the table 'serial'. This is a 1 to many relationship, and this reference does not make sense. The 'serialitems' table handles the relationship between the 'items' table and the 'serial' table. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify serial.itemnumber has been removed from the database Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Column removed. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! As a historical note, the serialitems table was added back in 2008. There was an upgrade concern that apparently prevented serial.itemnumber from being removed at the time that serialitems was added, but the code behind that that used to put a comma-separated list of itemnumbers into serial.itemnumber has long since been removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #3)
Yes, serials:items is a 1:many relationship. It seems to me that the correct solution here is not to populate serial.itemnumber, but rather to remove it so that no one thinks that they should be using it.
Jared: Could you tell me how I can create more than one item for one serial record? It just looks like a 1:1 relationship. Note that the table name serial is somewhat misleading. It actually is some kind of "subscription item". The relation between calling AddItem2Serial and NewIssue is not very clear in the current Koha code. If this is just 1:1, it would not have been a bad idea to remove the serialitems table? If it is not, I am even more interested.. Thanks. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org