https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41467 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190583&action=edit Bug 41467: Return from branch for transfer NotAllowed This patch adds the from branch to the returned error and simplifies the logic of the test We have effective_itemtype so don't need a conditional based on item type level To test: 1 - SET syspref UseBranchTransferLimits/BranchTransferLimitsType To Enfore based on collection 2 - Administration->Library Transfer limits click (Advanced editor) 3 - Uncheck Centerville->Fairfield for 'Fiction' 4 - Find or create a Fiction item at centerville 5 - Circulation->Transfer 6 - Attempt to transfer item to Fairfield 7 - Note 'Originating library' is blank 8 - Apply patch 9 - Restart all 10 - Attempt transfer again 11 - Error is fully populated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41467 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190583|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 190653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190653&action=edit Bug 41467: Return from branch for transfer NotAllowed This patch adds the from branch to the returned error and simplifies the logic of the test We have effective_itemtype so don't need a conditional based on item type level To test: 1 - SET syspref UseBranchTransferLimits/BranchTransferLimitsType To Enfore based on collection 2 - Administration->Library Transfer limits click (Advanced editor) 3 - Uncheck Centerville->Fairfield for 'Fiction' 4 - Find or create a Fiction item at centerville 5 - Circulation->Transfer 6 - Attempt to transfer item to Fairfield 7 - Note 'Originating library' is blank 8 - Apply patch 9 - Restart all 10 - Attempt transfer again 11 - Error is fully populated Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41467 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add tests. -- You are receiving this mail because: You are watching all bug changes.