https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This also applies to the debit type dropdown in Manual invoice. I think I was waiting on bug 24975 to base work on to make this more flexible with regards translations. I think it could be done, but wouldn't be trivial, using the existing template level include translations (the challenge is that the dropdown is built from a list of credit_types/debit_types whereas the existing template include is designed to receive accountline rows). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109701&action=edit Bug 26398: Restore translations for credit/debit type dropdown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |26403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 [Bug 26403] "Issue refund" is not fully translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Credit type on creating a |Credit and Debit types on |manual credit is not |creating a manual credits |translatable |and manual invoices are not | |translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This one is a bit challenging for me to write a test plan as I only just understand the translation workflow myself. What the patch does is update the templates to include the English strings for translation in the right places. Regression tests * Create some debts and payments of various types. * Check that they appear as expected in the accounts tables on both the transactions and pay tabs of the members page. Bug fix test * We need to check that the strings appear in .po files. I believe this is a case of running the 'update' method of misc/translator/translator script. * The final aim of the bug is to make the drop-down options for manual invoice and manual credit type drop downs are translated. Katrin, perhaps you could lend a hand on how this can be properly tested? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That's a great test plan Caroline, thanks, I shall grab it for other similar bugs.. thanks so much for t sting and moving this on. 😀 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111928|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111941&action=edit Bug 26398: Restore translations for credit/debit type dropdown 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111941|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112844&action=edit Bug 26398: Restore translations for credit/debit type dropdown 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply clean 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.