[Bug 39233] New: Non-patron guarantor info not dropped when patron category is updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Bug ID: 39233 Summary: Non-patron guarantor info not dropped when patron category is updated Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When child patrons category is updated via update_patrons_category.pl patrons relationship with their guarantor is dropped from borrower_relationships table. But non-patron guarantees info is still kept in borrowers table. To reproduce: 1. Find child patron with non-patron guarantor or create one. 2. Update patrons age so that their category is updated when you run following: perl misc/cronjobs/update_patrons_category.pl --confirm --too_old --from K --to PT 3. Check patrons info from borrowers table. => Note that values in contactname, contactfirstname and relationship columns were not dropped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 181364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181364&action=edit Bug 39233: Drop non-patron guarantor info when guarantee is updated as an adult via update_patrons_category.pl When child patrons category is updated via update_patrons_category.pl patrons relationship with their guarantor is dropped from borrower_relationships table. But non-patron guarantees info is still kept in borrowers table. This patch fixes this by setting non-patron guarantor columns in borrower table as undefined when patron is stored. To test: 1. Find child patron with non-patron guarantor or create one. 2. Update patrons age so that their category is updated when you run following: perl misc/cronjobs/update_patrons_category.pl --confirm --too_old --from K --to PT 3. Check patrons info from patrons detail page. => Note that non-patron guarantors info was not dropped. 4. Apply this patch. 5. Run cronjob again. => Non-patron guarantors info should have now dropped. Alsp prove t/db_dependent/Patrons.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39331 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181364|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 181827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181827&action=edit Bug 39233: Drop non-patron guarantor info when guarantee is updated as an adult via update_patrons_category.pl When child patrons category is updated via update_patrons_category.pl patrons relationship with their guarantor is dropped from borrower_relationships table. But non-patron guarantees info is still kept in borrowers table. This patch fixes this by setting non-patron guarantor columns in borrower table as undefined when patron is stored. To test: 1. Find child patron with non-patron guarantor or create one. 2. Update patrons age so that their category is updated when you run following: perl misc/cronjobs/update_patrons_category.pl --confirm --too_old --from K --to PT 3. Check patrons info from patrons detail page. => Note that non-patron guarantors info was not dropped. 4. Apply this patch. 5. Run cronjob again. => Non-patron guarantors info should have now dropped. Alsp prove t/db_dependent/Patrons.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |misc/cronjobs/update_patron | |s_category.pl script so | |that non-patron guarantor | |information is removed when | |the patron category is | |changed (for example, from | |a child to an adult | |patron). | | | |This now matches | |what happens when changing | |the patron category when a | |patron has patron | |guarantors (that is, the | |guarantor information is | |removed). CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. If I try to update the patron's age in the staff interface, I get this message: The following fields are wrong. Please fix them. - Patron's age is incorrect for their category. Ages allowed are 5-17. 2. You can't save the patron until you fix the category. 3. Instead, I updated in the database: update borrowers set dateofbirth="2000-05-01" where borrowernumber="37"; 4. After the patch is applied, update the patron again using the database to set the patron category back to "K": update borrowers set categorycode="K" where borrowernumber="37"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm considering asking for a switch for this.. I could see cases where this cleanup being automated may not be wanted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39363 --- Comment #5 from David Nind <david@davidnind.com> --- Is bug 32915 a duplicate? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32195 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |In Discussion --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- In view of comment4 and comment5 moving to In Discussion. Please provide clarity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to David Nind from comment #5)
Is bug 32915 a duplicate?
Did you mean to comment this on different bug maybe? This bug is about patron info and that bug about framework defaults. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Martin Renvoize (ashimema) from comment #4)
I'm considering asking for a switch for this.. I could see cases where this cleanup being automated may not be wanted.
Can you provide an example when this info is still needed after guarantee is updated? I don't really see why we should keep this info around if we already drop it from patron guarantees. Is contact info used in some other situations apart from guarantee-guarantor cases? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32196 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Emmi Takkinen from comment #7)
(In reply to David Nind from comment #5)
Is bug 32915 a duplicate?
Did you mean to comment this on different bug maybe? This bug is about patron info and that bug about framework defaults.
Apologies, that was the wrong bug number - should have been bug 32195 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to David Nind from comment #9)
(In reply to Emmi Takkinen from comment #7)
(In reply to David Nind from comment #5)
Is bug 32915 a duplicate?
Did you mean to comment this on different bug maybe? This bug is about patron info and that bug about framework defaults.
Apologies, that was the wrong bug number - should have been bug 32195
Hmm, I'm not sure if they are same or not. The way I read it in bug 32195 if you have patron category A where "CanBeGuarantee" option is first set as Yes and then change that option as "No", the guarantor info is not dropped and it cannot be moved at all. Although... Recent change to the bugs title and Andrews comment suggest that it indeed is now a duplicate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Is there any way I can help on this ticket ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39233 --- Comment #12 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #11)
Is there any way I can help on this ticket ?
It's still waiting decision if we want to remove non-patron guarantors info or should it be optional. Personally I don't see point in keeping them but maybe there are situations when they are still needed(?). As for the is the bug 32195 duplicate of this bug, it is. But it differs slightly from this bug, since it suggests adding a flag to cron to make clean up optional. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org