https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41627 Bug 41627 depends on bug 41619, which changed state. Bug 41619 Summary: Add `Koha::CSV` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41619 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41627 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203489&action=edit Bug 41627: Use Koha::CSV for acquisition CSV exports This patch replaces direct Text::CSV_XS usage with Koha::CSV in: - C4/Acquisition.pm (GetBasketAsCSV with CSV profile) - admin/aqplan.pl (budget planning export) Both use the low-level API (combine/string) since columns are dynamic (determined by CSV profiles or budget structure at runtime). The sep_char from the CSV profile is passed through to Koha::CSV, overriding the system preference as intended. Benefits: - formula => empty enforced (prevents formula injection) - binary => 1 always set (UTF-8 safe) - Consistent with other CSV exports - Removes direct Text::CSV_XS dependency Test plan: 1. Apply patches (depends on bug 41620) 2. Create a basket with orders 3. Export basket as CSV (with and without a CSV profile) => SUCCESS: CSV generated correctly in both cases 4. Go to Administration > Budget planning > Export as CSV => SUCCESS: CSV exported with correct delimiter 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41627 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43278 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- I tried some truly awful strings for line items and it seems to work :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43278 [Bug 43278] Add Koha::CsvProfile->parsed_fields and profile-aware CSV export -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41627 --- Comment #3 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206478&action=edit Bug 41627: Use Koha::CSV for acquisition CSV exports This patch replaces direct Text::CSV_XS usage with Koha::CSV in: - C4/Acquisition.pm (GetBasketAsCSV with CSV profile) - admin/aqplan.pl (budget planning export) Both use the low-level API (combine/string) since columns are dynamic (determined by CSV profiles or budget structure at runtime). The sep_char from the CSV profile is passed through to Koha::CSV, overriding the system preference as intended. Benefits: - formula => empty enforced (prevents formula injection) - binary => 1 always set (UTF-8 safe) - Consistent with other CSV exports - Removes direct Text::CSV_XS dependency Test plan: 1. Apply patches (depends on bug 41620) 2. Create a basket with orders 3. Export basket as CSV (with and without a CSV profile) => SUCCESS: CSV generated correctly in both cases 4. Go to Administration > Budget planning > Export as CSV => SUCCESS: CSV exported with correct delimiter 5. Sign off :-D Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.