[Bug 20622] New: Add some color to bootstrap modal headers and footers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Bug ID: 20622 Summary: Add some color to bootstrap modal headers and footers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74557&action=edit Before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74558&action=edit After -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74559&action=edit Bug 20622: Add some color to bootstrap modal headers and footers Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. Test Plan: 1) Apply this patch 2) Find a patron, click the 'add message' button 3) Note the modal header and footer now have a background color -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Because of the way the modal is styled, changing the background color this way has a side-effect of eliminating the rounded corners on the modal. Since this wasn't an explicit choice I'm going to suggest an alternative: On line 2674: .modal-body { background-color: #FFF; overflow-y: auto; } .modal-content { background-color : #EDF4F6; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74559|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74606&action=edit Bug 20622: Add some color to bootstrap modal headers and footers Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. Test Plan: 1) Apply this patch 2) Find a patron, click the 'add message' button 3) Note the modal header and footer now have a background color Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- That looks perfect! Thanks Owen. I authored the patch in your name and added my sign-off to it! (In reply to Owen Leonard from comment #4)
Because of the way the modal is styled, changing the background color this way has a side-effect of eliminating the rounded corners on the modal. Since this wasn't an explicit choice I'm going to suggest an alternative:
On line 2674:
.modal-body { background-color: #FFF; overflow-y: auto; }
.modal-content { background-color : #EDF4F6; }
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74557|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74606|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74694&action=edit Bug 20622: Add some color to bootstrap modal headers and footers Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. Test Plan: 1) Apply this patch 2) Find a patron, click the 'add message' button 3) Note the modal header and footer now have a background color Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|kyle@bywatersolutions.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org