[Bug 24164] New: Patron emailer cronjob is not generating unique content for notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Bug ID: 24164 Summary: Patron emailer cronjob is not generating unique content for notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The content is being copied from one patron to all notices - it is because we are nesting a hashref so end up with a pointer instead of a new copy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC|robin@catalyst.net.nz |andrew@bywatersolutions.com | |, | |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95982&action=edit Bug 24164: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95983&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone@anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95983|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96040&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone@anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |wizzyrea@gmail.com Severity|normal |blocker --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Potential for the wrong data to be sent to borrowers, upping the severity/priority. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96040|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96211&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone@anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #6 from Jessie Zairo <jzairo@bywatersolutions.com> --- Anyone else who tests, make sure to also set the following: In step 2 (make sure you add email to the SELECT statement and add a FROM statement - Create a report - note the report id SELECT borrowernumber, surname, firstname, email FROM borrowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16149 QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 [Bug 16149] Generate and send custom notices based on report output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95982|0 |1 is obsolete| | Attachment #96211|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96220&action=edit Bug 24164: Unit test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96221&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id ($REPORT_ID) SELECT borrowernumber, surname, firstname, email FROM borrowers WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report $REPORT_ID --notice TESTEMAIL --module circulation --from anyone@anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org