[Bug 19413] New: Move the location of the Ok and cancel buttons to the 008 cataloguing builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Bug ID: 19413 Summary: Move the location of the Ok and cancel buttons to the 008 cataloguing builder Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The inputs that librarians are most likely to interact with on the Cataloguing 008 Builder are types of materials, and dates which are all at the top of the window. The patch attached to this bug report will place the OK and cancel inputs at the top of the page therefore improving the UX of the page because they don't have to scroll past a whole lot of unnecessary inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67623&action=edit Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Test plan: 1. Go into the Cataloguing module in the staff intranet 2. Create a new record in one of your MARC frameworks 3. Click on the small tag editor icon to the right of the 008 field 4. A new window (containing the 008 builder) will appear and notice that the OK and cancel buttons are at the bottom of the page in this window 5. Apply patch 6. Refresh this window (right click and select refresh button) 7. Notice that the OK and cancel buttons have moved to the top right of the page Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67623|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 67626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67626&action=edit Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Followed test plan and patch applies and functions as described Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I see that git grep "id=\"action\"" returns various results. Please explain why your change in staff-global would not have various side effects? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67979&action=edit Bug 19413 - Followup Changed fieldset id value Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Marcel Apologies I made a mistake in not making the id value more specific. I have made the id value "fixedlengthbuilderaction" in the followup patch I have just attached to this bug report. Please test again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67979|0 |1 is obsolete| | --- Comment #6 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 67984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67984&action=edit Bug 19413 - Followup Changed fieldset id value Followed test plan again and patch still applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67626|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68053&action=edit Bug 19413 - Moving the OK and Cancel inputs to the top of the 008 builder Followed test plan and patch applies and functions as described Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67984|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68054&action=edit Bug 19413 - Followup Changed fieldset id value Followed test plan again and patch still applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Alex Buckley from comment #5)
Hi Marcel
Apologies I made a mistake in not making the id value more specific. I have made the id value "fixedlengthbuilderaction" in the followup patch I have just attached to this bug report. Please test again
Thx. Cool name ;) QA Comment: As mentioned in first comment, this will help librarians only adjusting information at the top of the form. Sounds reasonable. On the other hand those librarians that need to adjust something too at the end will now complain :) Would be interesting to make it floating like the cataloguing editor itself? No blocker for me. Especially since hitting Enter here submits the form too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 70480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70480&action=edit Screenshot of translated Plugin This doesn't work so well with languages where the term "Cancel" is translated to a longer word. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 [Bug 19970] Revise change of bug 19413 to work better for translations -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org