[Bug 24644] New: Hold not marked filled if item set to positive not for loan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Bug ID: 24644 Summary: Hold not marked filled if item set to positive not for loan value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Confirmed in master and 19.05. To test: 1: make sure AllowNotForLoanOverride is set to allow 2: place a hold on an item with notforloan=0 3: check item in, confirm hold now shows Waiting 4: edit item, set notforloan to any positive value 5: check item out, performing override to allow checkout 6: confirm hold still shows Waiting Not a situation one expects to see often, but confusing when it pops up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have tracked this down a bit. The problem is that MoveReserve (called by AddIssue) calls CheckReserves: 1863 my ( $restype, $res, undef ) = CheckReserves( $itemnumber, undef, $lookahead ); 1864 return unless $res; Here $res is not defined because of: 792 # if item is not for loan it cannot be reserved either..... 793 # except where items.notforloan < 0 : This indicates the item is holdable. 794 return if ( $notforloan_per_item > 0 ) or $notforloan_per_itemtype; I have no idea how to fix this and making sure I am not introducing a regression somewhere else. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99110&action=edit Bug 24644: Just a try That does not work, t/db_dependent/Reserves.t is failing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #2)
Created attachment 99110 [details] [review] Bug 24644: Just a try
That does not work, t/db_dependent/Reserves.t is failing
This patch does fix the reported issue however. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Items with positive NFL values are not holdable by definition. I think this is not something that can/should just be changed. The deeper problem is how we deal with 'enforced' holds (AllowHoldPolicyOverride), as they can cause all types of issues contradicting the hold rules. For item level holds, maybe the suggestion on bug 13559 could be an idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13559 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org