[Bug 39512] New: Error 500 when applying payout of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39512 Bug ID: 39512 Summary: Error 500 when applying payout of 0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I was testing something else and did not enter a payout amount, which resulted in an error 500. I think it should result in a warning or error message to tell the staff member that they forgot to enter a value in the payout input. To recreate: 1. Go to a patron account > Accounting 2. Click 'Create manual invoice' 3. Enter an amount 4. Click 'Save and pay' 5. Click 'Confirm' 6. Click 'Transactions' 7. Click 'Payout amount' (should the button even appear if the patron has 0 due?) 8. Click 'Confirm' It should say something like "Please enter a payout amount". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39512 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39512 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I bumped into this today as well. I've noticed if there's no accountlines for the borrower and you do a payout of $0 then it redirects, but if there are accountlines - even if the balances is 0 because of a $10 debit followed by a $10 credit, then you get the 500 error. Reproduced this in KTD on main. In the plack-error.log you get this error message: Exception 'Koha::Exceptions::Account::AmountNotPositive' thrown 'Payout amount passed is not positive' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39512 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I suspect that one of my libraries double clicked the button because it was slow to process the first click, so some accidental errors could be prevented by preventing double clicks. But... the key thing would be to handle the error more gracefully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org