[Bug 20217] New: Make header's catalog search menu into a split button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Bug ID: 20217 Summary: Make header's catalog search menu into a split button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 19474 When we turned the staff client header's search link into a menu, it added an extra click for those who want the advanced search by default. I propose that we turn it into a split-button type menu. Since the Bootstrap navbar doesn't include a built-in split button, my solution uses a link plus a dropdown menu, with some added JavaScript to tie the links' hover style together: http://zivotdesign.com/p/#1/15187161792537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71674&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71674|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72688&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not totally persuaded by the usability of this. The way it is now the distance between 'Search' and the arrow is bigger than the distance between the arrow and the next menu item which makes it a little confusing. I'd like to get others people's opinions on this. Btw: the more direct way to access the item search has been a big hit among our libraries! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72688|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73335&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73336&action=edit Bug 20217 (follow up) Compiled CSS This patch contains the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- Can't apply the dependency : Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19474: Convert staff client CSS to SCSS Applying: Bug 19474: (QA follow-up) Fix sass lint yaml configuration Applying: Bug 19474: (follow-up) Bring scss up to date with latest CSS changes Applying: Bug 19474: (follow-up) Compiled CSS Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 19474: (follow-up) Compiled CSS The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73335|0 |1 is obsolete| | Attachment #73336|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74807&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74808&action=edit Bug 20217: (follow up) Compiled CSS This patch contains the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #9 from Claire Gravely <claire_gravely@hotmail.com> --- I cannot get the attached compiled CSS to work - I think something went squiff there? Tested by applying first patch and running yarn build myself. All looks good. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I think we'll probably need to eliminate the requirement that a compiled CSS patch be included, since they'll fail to apply 99.9% of the time. In my opinion the compiled CSS patch doesn't need a signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74807|0 |1 is obsolete| | --- Comment #11 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 75299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75299&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blocked by bug 19474. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Bug 20217 depends on bug 19474, which changed state. Bug 19474 Summary: Convert staff client CSS to SCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74808|0 |1 is obsolete| | Attachment #75299|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77668&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77668|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77679&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- I really like this bug, but when I tested the hover didn't affect both and they were farther apart than expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #15)
I really like this bug, but when I tested the hover didn't affect both and they were farther apart than expected
This is what it looks like to me: https://zivotdesign.com/p/view.php?p=15357194449806 Do you see something different? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org