[Bug 23990] New: Move C4::Suggestions code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug ID: 23990 Summary: Move C4::Suggestions code to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23991 Blocks|15449 | --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 23991 - Move SearchSuggestion to Koha::Suggestions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 [Bug 24418] Add Koha::Biblio->suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug 23990 depends on bug 24418, which changed state. Bug 24418 Summary: Add Koha::Biblio->suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug 23990 depends on bug 23991, which changed state. Bug 23991 Summary: Move SearchSuggestion to Koha::Suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug 23990 depends on bug 33236, which changed state. Bug 33236 Summary: Move C4::Suggestions::NewSuggestion to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |baptiste.wojtkowski@biblibr | |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
git grep "GetSuggestion[^a-zA-Z]" C4/Acquisition.pm:use C4::Suggestions qw( GetSuggestion GetSuggestionFromBiblionumber ModSuggestion ); C4/Suggestions.pm:\%sth = &GetSuggestion($suggestionid) C4/Suggestions.pm:sub GetSuggestion { C4/Suggestions.pm: my $full_suggestion = GetSuggestion( $suggestion->{suggestionid} ); acqui/basket.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfoFromBiblionumber GetSuggestionInfo ); acqui/neworderempty.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfo ); acqui/neworderempty.pl: $data = GetSuggestion($suggestionid); acqui/orderreceive.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfoFromBiblionumber GetSuggestionInfo ); acqui/parcel.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfoFromBiblionumber GetSuggestionInfo ); misc/release_notes/release_notes_3_20_0.txt: 13201 normal GetSuggestion takes suggestionid suggestion/suggestion.pl: $suggestion_ref = &GetSuggestion( $$suggestion_ref{'suggestionid'} ); suggestion/suggestion.pl: $suggestion_ref = &GetSuggestion( $$suggestion_ref{'suggestionid'} ); t/db_dependent/Suggestions.t: qw( GetSuggestion ModSuggestion GetSuggestionInfo GetSuggestionFromBiblionumber GetSuggestionInfoFromBiblionumber GetSuggestionByStatus ConnectSuggestionAndBiblio DelSuggestion MarcRecordFromNewSuggestion GetUnprocessedSuggestions DelSuggestionsOlderThan ) t/db_dependent/Suggestions.t:is( GetSuggestion(), undef, 'GetSuggestion without
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- the suggestion id returns undef' ); t/db_dependent/Suggestions.t:my $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid_test_budgetid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid_test_budgetid); t/db_dependent/Suggestions.t: my $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t: $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t: $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t: $suggestion = GetSuggestion($my_suggestionid); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180826&action=edit Bug 23990: Remove GetSuggestion from C4/Suggestions.pm This set of patches removes the major part of C4/Suggestions. They have been split for sake of QA's readability but should be squashed. Things to test: Create suggestion Update status of suggestion Create, see and receive an order containing a suggestion Create a suggestion on an already existing record (it will need validation) test cronjobs purge_suggestion and notice_unprocessed_suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180827&action=edit Bug 23990: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180828&action=edit Bug 23990: Remove GetSuggestionInfoFromBiblionumber from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180829&action=edit Bug 23990: Remove GetSuggestionInfo from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180830&action=edit Bug 23990: Remove GetSuggestionByStatus from C4/Suggestions.pm Note: not used in koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180831&action=edit Bug 23990: Remove op connectDuplicate from acqui/newordersuggestions.pl 15:27:09> git grep connectDuplicate acqui/newordersuggestion.pl: * connectDuplicate : acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) { connectDuplicate is never called from any template code is hence removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180832&action=edit Bug 23990: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180833&action=edit Bug 23990: Remove DelSuggestionsOlderThan from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180834&action=edit Bug 23990: Add option -exact_days to filter_by_last_update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180835&action=edit Bug 23990: Remove GetUnprocessedSuggestions from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180836&action=edit Bug 23990: Remove DelSuggestions from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180837&action=edit Bug 23990: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 [Bug 39732] Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39732 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 [Bug 39732] Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42070 [Bug 42070] Remove ModSuggestion from C4/Suggestion.pm -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org