[Bug 24356] New: objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Bug ID: 24356 Summary: objects.search prefetch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org It would be great if objects.search added the prefetch automatically when an embed action is requested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 [Bug 24321] Make objects.search use mappings from Koha::Object(s) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97680&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97681&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is missing tests for the helpers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 [Bug 24502] objects.search filter by prefetched columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97680|0 |1 is obsolete| | Attachment #97681|0 |1 is obsolete| | --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97848&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97849&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97848|0 |1 is obsolete| | Attachment #97849|0 |1 is obsolete| | --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97851&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97852&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Tomás Cohen Arazi from comment #3)
This is missing tests for the helpers.
Just added missing tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97851|0 |1 is obsolete| | Attachment #97852|0 |1 is obsolete| | --- Comment #9 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97935&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #10 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97936&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #11 from David Nind <david@davidnind.com> --- Tests fail: prove t/db_dependent/Koha/Object* t/db_dependent/Koha/Objects.t .. 18/21 # Failed test 'Relationship matching method name is listed' # at t/db_dependent/Koha/Objects.t line 800. # Failed test 'Guessed the object class correctly' # at t/db_dependent/Koha/Objects.t line 804. # got: undef # expected: 'Koha::Acquisition::BasketGroup' # Looks like you failed 2 tests of 2. # Failed test 'prefetch_whitelist() tests' # at t/db_dependent/Koha/Objects.t line 809. # Looks like you failed 1 test of 21. t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests t/db_dependent/Koha/Object.t ... 17/18 # Failed test 'Relationship matching method name is listed' # at t/db_dependent/Koha/Object.t line 754. # Failed test 'Guessed the object class correctly' # at t/db_dependent/Koha/Object.t line 758. # got: undef # expected: 'Koha::Acquisition::BasketGroup' # Looks like you failed 2 tests of 2. # Failed test 'prefetch_whitelist() tests' # at t/db_dependent/Koha/Object.t line 763. # Looks like you failed 1 test of 18. t/db_dependent/Koha/Object.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/18 subtests Test Summary Report ------------------- t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 21 Non-zero exit status: 1 t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 18 Non-zero exit status: 1 Files=2, Tests=39, 22 wallclock secs ( 0.05 usr 0.01 sys + 17.92 cusr 3.05 csys = 21.03 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97935|0 |1 is obsolete| | Attachment #97936|0 |1 is obsolete| | --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98261&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #13 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98262&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #14 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to David Nind from comment #11)
Tests fail:
prove t/db_dependent/Koha/Object*
t/db_dependent/Koha/Objects.t .. 18/21 # Failed test 'Relationship matching method name is listed' # at t/db_dependent/Koha/Objects.t line 800.
# Failed test 'Guessed the object class correctly' # at t/db_dependent/Koha/Objects.t line 804. # got: undef # expected: 'Koha::Acquisition::BasketGroup' # Looks like you failed 2 tests of 2.
# Failed test 'prefetch_whitelist() tests' # at t/db_dependent/Koha/Objects.t line 809. # Looks like you failed 1 test of 21. t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests t/db_dependent/Koha/Object.t ... 17/18 # Failed test 'Relationship matching method name is listed' # at t/db_dependent/Koha/Object.t line 754.
# Failed test 'Guessed the object class correctly' # at t/db_dependent/Koha/Object.t line 758. # got: undef # expected: 'Koha::Acquisition::BasketGroup' # Looks like you failed 2 tests of 2.
# Failed test 'prefetch_whitelist() tests' # at t/db_dependent/Koha/Object.t line 763. # Looks like you failed 1 test of 18. t/db_dependent/Koha/Object.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/18 subtests
Test Summary Report ------------------- t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 21 Non-zero exit status: 1 t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 18 Non-zero exit status: 1 Files=2, Tests=39, 22 wallclock secs ( 0.05 usr 0.01 sys + 17.92 cusr 3.05 csys = 21.03 CPU) Result: FAIL
Hi David, thanks for testing. I just rebased and fixed tests. Could you please do another run? Regards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #15 from David Nind <david@davidnind.com> --- Tests for prove t/db_dependent/Koha/REST/Plugin/Query.t generate this error message: Cannot detect source of 't/db_dependent/Koha/REST/Plugin/Query.t'! at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261. TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x562a13917438), TAP::Parser::Source=HASH(0x562a13917510)) called at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211 TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x562a13917438), TAP::Parser::Source=HASH(0x562a13917510)) called at /usr/share/perl/5.24/TAP/Parser.pm line 472 TAP::Parser::_initialize(TAP::Parser=HASH(0x562a139170f0), HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 55 TAP::Object::new("TAP::Parser", HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 130 TAP::Object::_construct(TAP::Harness=HASH(0x562a1314e3f0), "TAP::Parser", HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Harness.pm line 852 TAP::Harness::make_parser(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Scheduler::Job=HASH(0x562a13837648)) called at /usr/share/perl/5.24/TAP/Harness.pm line 651 TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Aggregator=HASH(0x562a13168d48), TAP::Parser::Scheduler=HASH(0x562a138375e8)) called at /usr/share/perl/5.24/TAP/Harness.pm line 743 TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Aggregator=HASH(0x562a13168d48), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/TAP/Harness.pm line 558 TAP::Harness::__ANON__() called at /usr/share/perl/5.24/TAP/Harness.pm line 571 TAP::Harness::runtests(TAP::Harness=HASH(0x562a1314e3f0), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/App/Prove.pm line 546 App::Prove::_runtests(App::Prove=HASH(0x562a13143888), HASH(0x562a135b1c90), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/App/Prove.pm line 504 App::Prove::run(App::Prove=HASH(0x562a13143888)) called at /usr/bin/prove line 13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98262|0 |1 is obsolete| | --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98348&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #17 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to David Nind from comment #15)
Tests for prove t/db_dependent/Koha/REST/Plugin/Query.t generate this error message:
Cannot detect source of 't/db_dependent/Koha/REST/Plugin/Query.t'! at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261. TAP::Parser::IteratorFactory::detect_source(TAP::Parser:: IteratorFactory=HASH(0x562a13917438), TAP::Parser::Source=HASH(0x562a13917510)) called at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211 TAP::Parser::IteratorFactory::make_iterator(TAP::Parser:: IteratorFactory=HASH(0x562a13917438), TAP::Parser::Source=HASH(0x562a13917510)) called at /usr/share/perl/5.24/TAP/Parser.pm line 472 TAP::Parser::_initialize(TAP::Parser=HASH(0x562a139170f0), HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 55 TAP::Object::new("TAP::Parser", HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 130 TAP::Object::_construct(TAP::Harness=HASH(0x562a1314e3f0), "TAP::Parser", HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Harness.pm line 852 TAP::Harness::make_parser(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Scheduler::Job=HASH(0x562a13837648)) called at /usr/share/perl/5.24/TAP/Harness.pm line 651 TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Aggregator=HASH(0x562a13168d48), TAP::Parser::Scheduler=HASH(0x562a138375e8)) called at /usr/share/perl/5.24/TAP/Harness.pm line 743 TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x562a1314e3f0), TAP::Parser::Aggregator=HASH(0x562a13168d48), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/TAP/Harness.pm line 558 TAP::Harness::__ANON__() called at /usr/share/perl/5.24/TAP/Harness.pm line 571 TAP::Harness::runtests(TAP::Harness=HASH(0x562a1314e3f0), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/App/Prove.pm line 546 App::Prove::_runtests(App::Prove=HASH(0x562a13143888), HASH(0x562a135b1c90), "t/db_dependent/Koha/REST/Plugin/Query.t") called at /usr/share/perl/5.24/App/Prove.pm line 504 App::Prove::run(App::Prove=HASH(0x562a13143888)) called at /usr/bin/prove line 13
Ups!.. the path of Query.t was not in db_dependent. Sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98261|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 98353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98353&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98348|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 98354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98354&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98353|0 |1 is obsolete| | Attachment #98354|0 |1 is obsolete| | --- Comment #20 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98543&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #21 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 98544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98544&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #22 from Agustín Moyano <agustinmoyano@theke.io> --- Patches didn't apply so rebased this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Bug 24356 depends on bug 24321, which changed state. Bug 24321 Summary: Make objects.search use mappings from Koha::Object(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98543|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 98602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98602&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98544|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 98603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98603&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #25 from David Nind <david@davidnind.com> --- (In reply to Agustín Moyano from comment #22)
Patches didn't apply so rebased this bug.
Not sure I needed to, but signed off again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98602|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99349&action=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98603|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99350&action=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Well written and clear patch which passes all qa script tests and works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes the release notes| |Koha::Object(s) derived | |classes expose information | |about prefetch-able | |relations. This is then | |used by a new helper to | |generate the prefetch | |information for the DBIC | |query. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830 [Bug 24830] dbic_merge_prefetch is not handling recursive cases correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #30 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25044 [Bug 25044] No need to define koha_object[s]_çlass for standard object class names -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org