[Bug 16770] New: Remove wrong uses of Memoize::Memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Bug ID: 16770 Summary: Remove wrong uses of Memoize::Memcached Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org
From C4/languages.pm: 32 eval { 33 if (C4::Context->ismemcached) { 34 require Memoize::Memcached; 35 import Memoize::Memcached qw(memoize_memcached); 36 37 memoize_memcached('getTranslatedLanguages', memcached => C4::Context->memcached); 38 memoize_memcached('getFrameworkLanguages' , memcached => C4::Context->memcached); 39 memoize_memcached('getAllLanguages', memcached => C4::Context->memcached); 40 } 41 };
Looking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16579 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52513&action=edit Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52514&action=edit Bug 16770: Remove Memoize::Memcached dependency This module is no loguer in used and can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52514|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52515&action=edit Bug 16770: Remove Memoize::Memcached dependency This module is no longer in used and can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52513|0 |1 is obsolete| | --- Comment #4 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 52555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52555&action=edit Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52555|0 |1 is obsolete| | --- Comment #5 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 52556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52556&action=edit Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52515|0 |1 is obsolete| | --- Comment #6 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 52557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52557&action=edit Bug 16770: Remove Memoize::Memcached dependency This module is no longer in use and can be removed. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> This part involves some changes in a bunch of mysterious debian|ubuntu related files, not quite sure if I know what I'm doing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 --- Comment #7 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Some references to 'memoize' are still left in ./install_misc/ubuntu.10.04.packages:libmemoize-memcached-perl install ./install_misc/ubuntu.12.04.packages:libmemoize-memcached-perl install not sure if those files (whatever they are) are still relevent or not? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52640&action=edit Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jacek Ablewicz from comment #7)
Some references to 'memoize' are still left in
./install_misc/ubuntu.10.04.packages:libmemoize-memcached-perl install ./install_misc/ubuntu.12.04.packages:libmemoize-memcached-perl install
not sure if those files (whatever they are) are still relevent or not?
They should be removed as well indeed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52640|0 |1 is obsolete| | --- Comment #10 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 52678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52678&action=edit Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52556|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 52712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52712&action=edit Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52557|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 52713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52713&action=edit Bug 16770: Remove Memoize::Memcached dependency This module is no longer in use and can be removed. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> This part involves some changes in a bunch of mysterious debian|ubuntu related files, not quite sure if I know what I'm doing Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52678|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 52714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52714&action=edit Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7879 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16770 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org