[Bug 22831] New: Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bug ID: 22831 Summary: Elasticsearch - add a maintenance script for checking DB vs index counts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89233&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elastic_search.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com, | |ere.maijala@helsinki.fi, | |glasklas@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89233|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95077&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elastic_search.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Ere Maijala <ere.maijala@helsinki.fi> --- I think this needs to display some sort of progress message. Otherwise it looks like it just hangs with high CPU usage. And please fix "elastic search" to "Elasticsearch" in the comment while at it. :) It would also be useful to check from which array a record is missing and tell it to the user. Since we already have the information in the arrays, let's help the user out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #4 from Michal Denar <black23@gmail.com> --- Hi Nick, I troed to test it with Kohadevbox, but get this error on step 3: Can't locate Koha/Items.pm in @INC (you may need to install the Koha::Items module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at compare_es_to_db.pl line 33. BEGIN failed--compilation aborted at compare_es_to_db.pl line 33. I'm really not sure about this issue. It can be based at Kohadevbox instalation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #5 from Ere Maijala <ere.maijala@helsinki.fi> --- That's a weird one. The script worked for me in my dev environment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #6 from Ere Maijala <ere.maijala@helsinki.fi> --- Nick, one more thing: you can make the ES cursor a zillion times faster by not retrieving any of the stored fields: my $scroll = $es->scroll_helper( index => $searcher->get_elasticsearch_params->{index_name}, size => 5000, body => { query => { match_all => {} }, stored_fields => [] }, scroll_in_qs => 1, ); I'd also run the id comparison regardless of whether record counts match since there's could be a case where they do but the records still differ. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95077|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95105&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #8 from Ere Maijala <ere.maijala@helsinki.fi> --- Nick, did you consider my suggestion about more informative result display: It would also be useful to check from which array a record is missing and tell it to the user. Since we already have the information in the arrays, let's help the user out. Also, maybe a running counter when fetching the records? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95109&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95109|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95110&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Ere Maijala <ere.maijala@helsinki.fi> --- The url is a nice touch! A few issues remain, though: 1.) I'd still fetch the base urls outside the loop. Would improve readability and avoid repeated pref calls. 2.) For authorities, the OPAC URLs are now invalid. They should be something like [...]/cgi-bin/koha/opac-authoritiesdetail.pl?authid=123. 3.) The patch for PerlDependencies.pl is borked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Very nice script, thanks a lot ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95105|0 |1 is obsolete| | Attachment #95110|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95154&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95155&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95154|0 |1 is obsolete| | --- Comment #15 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 95156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95156&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95155|0 |1 is obsolete| | --- Comment #16 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 95157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95157&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- record ids should be sorted numerically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95176&action=edit Bug 22831: (follow-up) Sort results, group by db -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95156|0 |1 is obsolete| | --- Comment #19 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 96804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96804&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95157|0 |1 is obsolete| | --- Comment #20 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 96805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96805&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95176|0 |1 is obsolete| | --- Comment #21 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 96806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96806&action=edit Bug 22831: (follow-up) Sort results, group by db Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96804|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97339&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96805|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97340&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96806|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97341&action=edit Bug 22831: (follow-up) Sort results, group by db Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would have preferred to not add the new deps, but not blocker. Thanks for the follow-up Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Haha, I agree.. I would have preferred not to add a new dependancy... especially as it doesn't appear to be packaged for Jessie (having said that.. we are dropping supoprt for Jessie with 20.05 and this is an enhancement so that shouldn't be a problem). However.. I am wondering a little about the code having had a little read. You seem to do an array_diff and then two more iterations to catch where the diffs came from.. couldn't you have just done two array_minus calls (from the same module) to directly get the two different types of problem and saved yourself a loop and a few lines of code? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97783&action=edit Bug 22831: (RM follow-up) Code golf Rather than performing a symmetric diff and then splitting the results in a further loop this patch changes to logic to use two asymetric diffs to get the results more directly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #29 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- choosing not backport enhancement to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - add a |Add a maintenance script |maintenance script for |for checking DB vs index |checking DB vs index counts |counts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- I wrote something like this for Zebra a long time ago, and while it is useful, it would be great to check if the contents of both the DB and the Index were the same. (For instance, the counts might be the same as you may not have added/deleted in a while, but the contents may still be different, if your updates aren't working.) What do people think about adding a checksum in a MARC field and indexing that? (Alternatively, I suppose we could just use the 005, although I don't know how reliably that is updated.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26382 [Bug 26382] misc/maintenance/compare_es_to_db.pl is missing execution permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17382 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 17382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38386 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38386 [Bug 38386] compare_es_to_db.pl shouldn't retrieve the records from ES -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38762 [Bug 38762] compare_es_to_db.pl should provide links to the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36365 [Bug 36365] compare-es-to-db tool should offer a mode to reconcile differences -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org