[Bug 16951] New: Item search sorting not working properly for most columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Bug ID: 16951 Summary: Item search sorting not working properly for most columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When I pull up items in the item search and arrange by title, publication year, publisher, itemcallnumber, etc. I am getting results that don't seem to make any sense. I am seeing reports of this in 3.22.8 as well The order seems to be the same no matter what column, and it almost appears as if they are being ordered by date accessioned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu --- Comment #1 from Tom Misilo <misilot@fit.edu> --- This seems to be a regression from 3.18, as we were able to sort on call numbers before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |major --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, I am pretty sure too that this worked in 3.18 - as a regression I am upping severity a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58243&action=edit Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58244&action=edit Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58243|0 |1 is obsolete| | Attachment #58244|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 58381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58381&action=edit Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 58382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58382&action=edit Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58381|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58384&action=edit Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58382|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58385&action=edit Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org