[Bug 25654] New: Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Bug ID: 25654 Summary: Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 105490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105490&action=edit differences With the recent change of the Guarantors in Koha, the Contact section of the Patron Detail page (when editing) is confusing. Prior to 19.11, the Contact section was created for the Contact details of the Patron, phone, email, fax. Now in 19.11, the Guarantor (Non-Koha) has been added to the contact section, causing questions if this is the Guarantor's contact information or the primary patron's contact information. It would be nice if there could be a separation of the two areas in the Koha patrons form (memberentry.pl) Attaching an image of the before 19.11 and 19.11 contact section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1, this is confusing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- +1 I agree that the non-patron Guarantor information should go in the 'Guarantor information' section rather than the 'Contact' section. We could hide it behind a button. I would put a button next to the 'Search to add' button that says something like 'Guarantor is not a patron'. Or have it like pre-19.11 where the non-patron fields are always showing and you can click on 'Search to add' to fill them, but I admit that I didn't find that it was very intuitive... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #3 from Lisette Scheer <lisetteslatah@gmail.com> --- +1 it seems like the non-patron Guarantor should be with patron Guarantors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #4 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Is the implication if we move those fields that the non-patron guarantors will not have contact information? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Benjamin Daeuber from comment #4)
Is the implication if we move those fields that the non-patron guarantors will not have contact information?
The contact information is that of the patron, not the guarantor. That is the main confusion reported by Kelly. I also find it confusing to have a section named 'Guarantor information', and then other fields named 'Guarantor something' that are not in that section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #6 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- I guess my point is that (In reply to Caroline Cyr La Rose from comment #5)
The contact information is that of the patron, not the guarantor. That is the main confusion reported by Kelly.
I think we need additional contact fields if this is the case. A whole separate section for non-patron guarantor contact information labeled "Non-Patron Guarantor". Right now there is essentially one set of contact info and it appears like it could belong to the non-patron guarantor who doesn't actually have any contact info. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Pre-19.11, the alternate contact section would be used for that. But I agree that yours is a good idea. That would mean moving the Alternate contact section to the 'Guarantor information' section and only making it appear if we choose 'Non-patron guarantor', I guess? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #8 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- (In reply to Caroline Cyr La Rose from comment #7)
Pre-19.11, the alternate contact section would be used for that.
But I agree that yours is a good idea. That would mean moving the Alternate contact section to the 'Guarantor information' section and only making it appear if we choose 'Non-patron guarantor', I guess?
We use the alternate contact for adults that have guarantors, but which we can't actually add guarantors to (which is a whole other issue). So I think we need a whole new set of contact information. And I'm not sure of the original intent of the development, but as it stands now, I think this is a serious issue if we are indeed distinguishing between alternate contact and non-patron guarantor contact. And if we're not, why add the non-patron guarantor feature at all? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> ---
And I'm not sure of the original intent of the development, but as it stands now, I think this is a serious issue if we are indeed distinguishing between alternate contact and non-patron guarantor contact. And if we're not, why add the non-patron guarantor feature at all?
Pre-19.11 we could add non-patron guarantors in the guarantor information (only first and last names). I think that's why we want to keep it. I suggest you go give a +1 to bug 12446 which is to allow adults (or any patron category in fact) to have guarantors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Making the Contact Section |Make the contact and |/ Guarantor Section |non-patron guarantor |separate from the Contact |sections separate on patron |details of the patron would |entry form |be less confusing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #10 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Is there a sense of who's using the alternate contact fields other than for guarantor information? We use the alternate address for college students and people who might own property in town but actually live out of town. We mostly use the alternate contact field as described above, but I would hate to shoehorn guarantor information into those fields if they are in use otherwise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Guarantors are usually assumed to be parents or guardians. That's why there is the option to show the guarantee's checkouts to the guarantor. Having a separate alternate contact allows there to be a greater separation between the patron and the contact. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106351&action=edit Bug 25654: Make the contact and non-patron guarantor sections separate on patron entry form This patch reverses what I think was an unintended change made by Bug 14570 in which the non-patron guarantor fields are shown for all patron types (not just child patrons) and grouped with the patron contact fields. This patch creates a new "Non-patron guarantor" fieldset to show along with "Patron guarantor" when adding or editing child patrons. To test, apply the patch check that the BorrowerUnwantedField system preference does not contain contactname, contactfirstname, or relationship. - Open an adult patron for editing. You should see no guarantor-related fields. - Open a child patron for editing. There should be two guarantor sections: "Patron guarantor" and "Non-patron guarantor." - Test that adding patron guarantors and non-patron guarantors works correctly. - Add "contactname|contactfirstname|relationship" to the BorrowerUnwantedField system preference. - Reload the child patron entry form. The non-patron guarantor section should now be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 25742 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106351|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106355&action=edit Bug 25654: Make the contact and non-patron guarantor sections separate on patron entry form This patch reverses what I think was an unintended change made by Bug 14570 in which the non-patron guarantor fields are shown for all patron types (not just child patrons) and grouped with the patron contact fields. This patch creates a new "Non-patron guarantor" fieldset to show along with "Patron guarantor" when adding or editing child patrons. To test, apply the patch check that the BorrowerUnwantedField system preference does not contain contactname, contactfirstname, or relationship. - Open an adult patron for editing. You should see no guarantor-related fields. - Open a child patron for editing. There should be two guarantor sections: "Patron guarantor" and "Non-patron guarantor." - Test that adding patron guarantors and non-patron guarantors works correctly. - Add "contactname|contactfirstname|relationship" to the BorrowerUnwantedField system preference. - Reload the child patron entry form. The non-patron guarantor section should now be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106355|0 |1 is obsolete| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 106456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106456&action=edit Bug 25654: Make the contact and non-patron guarantor sections separate on patron entry form This patch reverses what I think was an unintended change made by Bug 14570 in which the non-patron guarantor fields are shown for all patron types (not just child patrons) and grouped with the patron contact fields. This patch creates a new "Non-patron guarantor" fieldset to show along with "Patron guarantor" when adding or editing child patrons. To test, apply the patch check that the BorrowerUnwantedField system preference does not contain contactname, contactfirstname, or relationship. - Open an adult patron for editing. You should see no guarantor-related fields. - Open a child patron for editing. There should be two guarantor sections: "Patron guarantor" and "Non-patron guarantor." - Test that adding patron guarantors and non-patron guarantors works correctly. - Add "contactname|contactfirstname|relationship" to the BorrowerUnwantedField system preference. - Reload the child patron entry form. The non-patron guarantor section should now be hidden. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106456|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106457&action=edit Bug 25654: Make the contact and non-patron guarantor sections separate on patron entry form This patch reverses what I think was an unintended change made by Bug 14570 in which the non-patron guarantor fields are shown for all patron types (not just child patrons) and grouped with the patron contact fields. This patch creates a new "Non-patron guarantor" fieldset to show along with "Patron guarantor" when adding or editing child patrons. To test, apply the patch check that the BorrowerUnwantedField system preference does not contain contactname, contactfirstname, or relationship. - Open an adult patron for editing. You should see no guarantor-related fields. - Open a child patron for editing. There should be two guarantor sections: "Patron guarantor" and "Non-patron guarantor." - Test that adding patron guarantors and non-patron guarantors works correctly. - Add "contactname|contactfirstname|relationship" to the BorrowerUnwantedField system preference. - Reload the child patron entry form. The non-patron guarantor section should now be hidden. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- Clean and straight forward. Thanks for fixing this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106457|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108363&action=edit Bug 25654: Make the contact and non-patron guarantor sections separate on patron entry form This patch reverses what I think was an unintended change made by Bug 14570 in which the non-patron guarantor fields are shown for all patron types (not just child patrons) and grouped with the patron contact fields. This patch creates a new "Non-patron guarantor" fieldset to show along with "Patron guarantor" when adding or editing child patrons. To test, apply the patch check that the BorrowerUnwantedField system preference does not contain contactname, contactfirstname, or relationship. - Open an adult patron for editing. You should see no guarantor-related fields. - Open a child patron for editing. There should be two guarantor sections: "Patron guarantor" and "Non-patron guarantor." - Test that adding patron guarantors and non-patron guarantors works correctly. - Add "contactname|contactfirstname|relationship" to the BorrowerUnwantedField system preference. - Reload the child patron entry form. The non-patron guarantor section should now be hidden. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like this change, thx Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om --- Comment #22 from didier <didier.gautheron@biblibre.com> --- Hi, Is it possible to backport this one to 19.11? It's really confusing staff members and I think I have a working patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org